DO NOT MERGE: probe that pagelint --changed fires on pull_request - #73
Closed
iancooper wants to merge 1 commit into
Closed
DO NOT MERGE: probe that pagelint --changed fires on pull_request#73iancooper wants to merge 1 commit into
iancooper wants to merge 1 commit into
Conversation
…st event (spec 011, Task 5.2) One character inside the using-less C# block at AWSSQSConfiguration.md:29. The repo-wide pagelint step should stay green; the pull-request --changed step should go red on exactly that block. Closed and deleted once observed.
Member
Author
|
Probe succeeded — closing as planned, not merging. On the
The repo-wide step stayed green at |
iancooper
added a commit
that referenced
this pull request
Aug 5, 2026
Tasks 5.1, 5.2 and 5.3 ticked; 26 of 43. **AC6 is closed**: both tools run in CI and either one failing fails the build. The write-up is § *Phase 5 as executed*, and the part worth keeping is Task 5.2. Run locally, `--changed` reported 0 errors — the exact shape of the vacuous pass the task exists to rule out. Taken apart rather than accepted: `changed_ranges` returns 118 files and 465 hunks, so the ranges were real and this branch simply touches no C# block. The positive direction was then forced, first locally and then on PR #73, a one-character probe closed unmerged as soon as its run was read. What that run settled, and what no local check could: - on a `pull_request` event, where the checked-out ref is a merge commit, `origin/<base_ref>` **does** resolve. **The contingency `git fetch origin ${{ github.base_ref }}` is not needed and was not added.** - the run went red on `AWSSQSConfiguration.md:29` alone — the other fifteen blocks on that page stayed warnings — while the repo-wide step stayed green at 0 errors in the same run. The two strictness levels are independent in practice, not only in design. Also recorded: the `versions` guard was checked to propagate exit codes under `bash -e {0}`, including **2**, which 009 requires not be a pass; and why `base_ref` was moved off the command line. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012tcdwxVb8NmKaX2S6fvyFg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway probe for spec 011 Task 5.2. Expected to go red.
Task 5.2 exists because a
--changedstep that finds no changed ranges passes vacuously — the worst outcome, since the strict code rules would then never fire and the build would stay green while enforcing nothing.This PR changes one character inside the C# block at
contents/AWSSQSConfiguration.md:29, which has nousingdirectives. Expected:python3 tools/pagelint.py(repo-wide) — green, 0 errors / 840 warningspython3 tools/pagelint.py --changed origin/$BASE_REF— red, 1 error on that block aloneWill be closed and the branch deleted as soon as the run is observed. Do not merge.