GAUD-8851: proposed changes#7193
Merged
EdwinACL831 merged 1 commit intoJul 10, 2026
Merged
Conversation
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
EdwinACL831
marked this pull request as ready for review
July 10, 2026 14:05
EdwinACL831
merged commit Jul 10, 2026
3a68f1e
into
ecollazos/GAUD-8851_remove_text_scss
5 of 8 checks passed
EdwinACL831
added a commit
that referenced
this pull request
Jul 14, 2026
* GAUD-8851: Remove text.scss - Creates the input-text-styles.js file - Implements the style function generator - Mimics the text.scss styles based on the input-styles.js * Implements function to encapsulate similar styles generated * Exposes base styles from input-styles.js needed in input-text-styles.js * Updates input-text-styles.js to import and use base styles from input-styles.js * Exposes input base styles and selector delegates in orer to be used by input-text-styles.js * Updates input-text-styles.js to use the input base style delegates * Updates vdiffs to use generated input text styles * Removes function implementation and usage for disabled styles since they are already handled by the Input base styles by the :not(:disabled) * Updates selector order to avoid unexpected generated css * Removes sass vdiff tests * Updating vdiff goldens (#7162) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Adds unit test at node-imports-test-js * Revert "Updates vdiffs to use generated input text styles" This reverts commit b285bca. * Updates vdiffs to use generated input text styles * Updating vdiff goldens (#7186) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * GAUD-8851: proposed changes (#7193) * Adds a new generator function to crete the webkit styles. Deletes function comments since they are not longer public * Adds vdiff tests to make sure the webkit X for search inputs doesn't appear * Updating vdiff goldens (#7211) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Edwin Collazos <Edwin.Collazos@D2L.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dave Lockhart <dlockhart@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@EdwinACL831 @GZolla here's more detail about what I had in mind in this comment thread.
This has the advantage of not needing to
exportall the internal helpers, so external consumers can't use them at all. From BSI's perspective, calling_generateInputTextStyles()frominput-styles.jsinstead ofinput-text-styles.jsshould be no easier or harder.