Fix and prevent One Definition Rule (ODR) issues#2489
Merged
Conversation
paazmaya
force-pushed
the
one-definition-rule
branch
from
May 28, 2026 13:52
b78dc95 to
ec55f49
Compare
paazmaya
force-pushed
the
one-definition-rule
branch
2 times, most recently
from
June 14, 2026 06:45
02eabf5 to
ac8832d
Compare
Contributor
Author
|
Finally got the time to rebase this fully on top of the |
paazmaya
force-pushed
the
one-definition-rule
branch
from
June 19, 2026 05:50
ac8832d to
5bbd5a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Compiler was complaining about this ODR thing, so I went and tried to learn about it, fixed the existing issue and added a flag to prevent them getting in later.
Types of Changes
Bugfix