Potential fix for code scanning alert no. 1876: Uncontrolled command line#807
Conversation
…line Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @Bryan-Roe, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_d8b94637-fb63-4eb8-83c6-4bae3e858ec1) |
![bryan-roe-bot[bot]](https://avatars.githubusercontent.com/in/1073263?s=60&v=4){kind=small}
| result = subprocess.run( | ||
| cmd, | ||
| input=message, | ||
| capture_output=True, | ||
| text=True, | ||
| cwd=str(self.chat_path), | ||
| ) |
There was a problem hiding this comment.
Semgrep identified an issue in your code:
Detected subprocess function 'run' without a static string. If this data can be controlled by a malicious actor, it may be an instance of command injection. Audit the use of this call to ensure it is not controllable by an external resource. You may consider using 'shlex.escape()'.
To resolve this comment:
🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by dangerous-subprocess-use-audit.
You can view more details about this finding in the Semgrep AppSec Platform.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| result = subprocess.run(cmd, capture_output=True, text=True, cwd=str(self.chat_path)) | ||
| result = subprocess.run( | ||
| cmd, |
🔐 CodeQL — Open Alerts on this PR
Copilot Autofix suggestions (if enabled) appear as inline review comments on the affected lines. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_7ed80836-2f94-4c6d-9c92-114a2f255864) |
2 participants
Potential fix for https://github.com/Bryan-Roe/Aria/security/code-scanning/1876
General fix: remove user-controlled data from command-line arguments where possible; pass it through a safer channel (stdin or file) and keep command arguments fixed/allowlisted.
Best fix here without changing core functionality: keep using
subprocess.runwith an argv list, but stop appendingmessagetocmd. Instead, sendmessageviainput=messageso user content is not part of the command line. Keep provider allowlisting and existing message validation. Update onlymount/chat_integration.pyin thechat()method around command construction/execution (lines ~154–165 in the snippet).No new imports or external dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.
Note
Low Risk
Small, localized security hardening in chat subprocess invocation; behavior should match if
chat_cli.pyreads--onceinput from stdin.Overview
Addresses code scanning alert #1876 (uncontrolled command line) in
ChatIntegration.chat().User chat text is no longer appended to the
subprocess.runargv list ("--"+message). The CLI is invoked with a fixed argument list (--provider, allowlisted provider,--onceonly), and the message is sent withinput=messageon stdin. Existing provider allowlisting and_is_safe_cli_messagevalidation are unchanged.Reviewed by Cursor Bugbot for commit d9017f5. Bugbot is set up for automated code reviews on this repo. Configure here.