Harden markdownlint target selection to skip generated root guides#849
Conversation
|
@Bryan-Roe Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository and had to close this PR. The error I am seeing is: Once you or someone with the necessary access fixes the problem, please unassign and then reassign issue #0 to me and I'll retry. Thanks! |
|
@Bryan-Roe Thanks for sending me some feedback. Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository. The error I am seeing is: Once you or someone with the necessary access fixes the problem, please let me know in a comment and I'll try again. Thanks! |
There was a problem hiding this comment.
Sorry @Bryan-Roe, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@Bryan-Roe Thanks for sending me some feedback. Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository. The error I am seeing is: Once you or someone with the necessary access fixes the problem, please let me know in a comment and I'll try again. Thanks! |
There was a problem hiding this comment.
Pull request overview
Narrows Markdown linting to exclude generated root guides and adds a contract assertion.
Changes:
- Excludes
docs/root-guides/*from lint targets. - Tests that the exclusion remains configured.
- Review found stale local lint guidance.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/markdown-quality.yml |
Adds generated-guide exclusion. |
tests/test_markdown_quality_workflow.py |
Verifies exclusion presence. |
|
|
||
| case "$file" in | ||
| */node_modules/*|node_modules/*|*/.venv/*|.venv/*|*/venv/*|venv/*|*/.git/*|.git/*|*/dist/*|dist/*|*/build/*|build/*|*/.next/*|.next/*|*/.cache/*|.cache/*|data_out/*|mount/*|*/CHANGELOG.md|CHANGELOG.md) | ||
| */node_modules/*|node_modules/*|*/.venv/*|.venv/*|*/venv/*|venv/*|*/.git/*|.git/*|*/dist/*|dist/*|*/build/*|build/*|*/.next/*|.next/*|*/.cache/*|.cache/*|data_out/*|mount/*|docs/root-guides/*|*/CHANGELOG.md|CHANGELOG.md) |
The
markdownlintActions job was failing on generated docs underdocs/root-guides/with large volumes of MD060/MD007 violations. This change narrows markdown target selection so the workflow lints intended maintainable markdown sources only.Workflow change: target filter hardening
.github/workflows/markdown-quality.yml(Select markdown targetsstep).is_markdown_target()exclusion patterns to skip:docs/root-guides/*Contract test update
tests/test_markdown_quality_workflow.pyto assert the workflow script includes thedocs/root-guides/*exclusion, preventing drift.