Create Add Package-Measure Energy Savings Analyses.md#453
Merged
JieXiong9119 merged 9 commits intoBuildingSync:develop-v2from Jan 5, 2023
Merged
Conversation
laurenliz22
reviewed
Sep 30, 2022
| ### Example | ||
|
|
||
| Suppose that we have 2 arbitrary measures, #1 and #2. | ||
| Implementation of the first measure (as a whole) would cost $100 and would provide both electricity savings only. |
Contributor
There was a problem hiding this comment.
Suggested change
| Implementation of the first measure (as a whole) would cost $100 and would provide both electricity savings only. | |
| Implementation of the first measure (as a whole) would cost $100 and would provide electricity savings only. |
laurenliz22
approved these changes
Sep 30, 2022
Contributor
laurenliz22
left a comment
laurenliz22
left a comment
There was a problem hiding this comment.
Approve - looks great to me! had one minor change.
This commit implements the proposal by adding the `auc:MeasureSavingsAnalysis` child element to the `auc:MeasureID` element.
Bringing changes from PR#451
The recent change in PR BuildingSync#457 requires element `<auc:UsefulLife>` to be `xsd:nonNegativeInteger`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
N/A
What does this PR do?
New proposal to add "measure in the context of a package" energy savings analyses to the schema.
How should this be manually tested?
No testing required.
What are the relevant tickets?
N/A
Screenshots (if appropriate)