refactor(pifs): remove dead semantic retrieval code#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes dead PIFS semantic retrieval code left behind after converging semantic recall on
browse.Why
The current PIFS command surface routes semantic file discovery through
browse. Keeping old semantic fallback APIs, semantic folder projection helpers, and hybrid aggregate search paths adds unused behavior to pre-release code that should stay minimal.What Changed
PIFSCommandExecutorPageIndexFileSystem.search(..., semantic=True)fallback behavior andsearch_semantic_channel()semantic_folder_policy.pysummary,entity, andrelationchannel searchbrowse_semantic_files()instead of old search APIsVerification
/Users/chengjie/Projects/PageIndex/.venv/bin/python -m pytest tests -q->115 passed, 6 warningsgit diff --check HEAD~1..HEADCOMMAND_METHODS,search_semantic_channel,_semantic_search,apply_semantic_folder_projection,aggregate_hybrid_entity_relation, orsemantic_folder_policyRisk
Medium. This intentionally removes unpublished public helpers and semantic fallback paths. The active
browse/addsemantic paths remain covered by tests.