Unregister Listeners#58
Closed
krsmes wants to merge 1 commit intoBukkit:masterfrom
krsmes:unreg_listener
Closed
Conversation
Author
|
Original Pull Request: #55 |
Member
|
Your pull request doesn't follow our coding conventions outlined within each respective repo's README.md. |
Author
|
dang tabs… i had given up and rewritten my GroovyBukkit plugin to abstract listeners itself so it can register/deregister within itself. a 'native' unregister listener method would be much more efficient though. |
Member
|
I like the idea of being able to unregister listeners. If you fix this up, I'll discuss it with the team. |
Author
|
Fixed in new pull request #108 |
Author
|
replaced with #108 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to PluginManager, SimplePluginManager, and RegisteredListener to support unregistering RegisteredListeners
This is for performance so that all listeners do not have to be registered all the time.