feat(database-client): carry a row type through prepare - #193
Conversation
|
@codex review |
🦋 Changeset detectedLatest commit: 7ca96c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@bunny.net/database-client": minor | |||
There was a problem hiding this comment.
| "@bunny.net/database-client": minor | |
| "@bunny.net/database-client": patch |
Greptile SummaryThis PR carries row types from
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| packages/database-client/src/client.ts | Introduces generic statements and tuple-mapped batch results; the previously reported single-type and heterogeneous-batch inference gaps are addressed. |
| packages/database-client/src/client.test.ts | Adds coverage for statement-level row propagation, call-site overrides, single typed batches, heterogeneous batches, and column reads. |
| packages/database-client/src/index.ts | Exports the new BatchResults public type. |
| packages/database-client/README.md | Documents statement-level row typing and per-statement batch inference. |
| .changeset/database-client-prepare-generic.md | Records the database-client typing enhancement as a patch release. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
P[prepare<T>] --> S[Statement<T>]
S --> B[bind]
B --> E[all / first / run]
E --> R[Rows or Result typed as T]
S --> BA[batch tuple]
BA --> BR[Per-position BatchResults]
Reviews (3): Last reviewed commit: "fix(database-client): keep each statemen..." | Re-trigger Greptile
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…d mark the changeset patch
No description provided.