Conversation
Merge pull request #6 from Burki24/dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive "review hardening" of the
OpenShutterButtonControllibrary, focusing on robust initialization, improved configuration validation, safer runtime behavior, and enhanced user feedback. The changes ensure that all variable types and actions are correctly validated both in the configuration form and at runtime, movements are safely stopped in all relevant situations, and users receive clear status messages on configuration issues.Configuration and Validation Improvements
form.json) now restricts selectable variable types for button, movement, and position variables, and enforces required actions for movement and position variables. [1] [2]Runtime Safety and Movement Handling
User Feedback and Status Messaging
Other Enhancements
These changes collectively make the module much more robust, user-friendly, and safe to operate in production environments.