Add PVS editor#43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a PVS editor with (more or less) full functionality. The previous editor was, in reality, a bare-bones viewer. This viewer has remained largely the same barring some fixes, minor additions, and input changes, with the editor being built around it.
Usage of the editor is intended to be intuitive. The controls are as follows:
Zones may also be selected from the zone list in the right-side panel. All editing takes place in this panel; the viewer will update in real time when changes are made. Upon selecting a zone, it will be highlighted in red and its neighbours will be highlighted in yellow. A zone's points may be edited by changing their X/Y values. Neighbours and their flags may be edited after being selected from the neighbour list. Zones and neighbours may be added or removed using their respective "Add" and "Delete" buttons.
For simplicity's sake, only features used in the retail game are present. This leads to the following divergences from the full PVS feature set:
Again, these have no impact in practice as they are unused features in the retail game.
Also note: