Skip to content

Fix: replace bare except:pass with specific exception handling - #127

Closed
Ekaanksh-dev wants to merge 1 commit into
BusKill:masterfrom
Ekaanksh-dev:fix/bare-expect-pass-clauses
Closed

Fix: replace bare except:pass with specific exception handling#127
Ekaanksh-dev wants to merge 1 commit into
BusKill:masterfrom
Ekaanksh-dev:fix/bare-expect-pass-clauses

Conversation

@Ekaanksh-dev

Copy link
Copy Markdown

Fixes #115

Replaced 8 bare except: pass clauses in buskill/init.py
with specific except Exception as e and proper logging.

Changes:

  • Line 479: usb_handler.join() failures now logged
  • Line 492: upgrade_process.join() failures now logged
  • Line 498: wipeCache() failures now logged
  • Line 895: DATA_DIR failures now logged as warning
  • Line 935: usb_handler.kill/join failures now logged
  • Line 1601: umount failures now logged
  • Line 1610: makedirs/chmod failures now logged
  • Line 1867: KEYS file read failures now logged

@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

INFO: No unicode characters found in PR's commits

(source)

@maltfield

Copy link
Copy Markdown
Member

Thanks for the PR :)

Please note that this repo does not accept contributions that use AI

Can you please tell us if you wrote this code, comments, and PR contents entirely by yourself? Or if you used AI for any part of it?

@Ekaanksh-dev

Ekaanksh-dev commented Jun 8, 2026 via email

Copy link
Copy Markdown
Author

@Ekaanksh-dev
Ekaanksh-dev deleted the fix/bare-expect-pass-clauses branch June 20, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: 8 bare except:pass clauses silently swallowing all errors across buskill/__init__.py

2 participants