ci: trigger crates release on crates-v* tags - #23
Conversation
crates-v* was only ever written by the workflow, never accepted as a trigger, so pushing one released nothing. Accept it alongside the bare version tag and strip the prefix before the version check.
|
Warning Review limit reached
Next review available in: 19 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
crates-v0.1.1was pushed and nothing ran —publish-crates.ymlhas zero runs.Cause
crates-v*was only ever an output of the workflow: the tag it writes after a successful publish, so a release can be traced back to a commit. It was never accepted as an input trigger. The trigger pattern is:crates-v0.1.1does not match it, so the tag push was ignored.Fix
Accept both forms:
A bare version tag still releases both registries at once.
crates-v*now also releases the crates on their own, without touching PyPI — useful when only the Rust side needs recutting.The version check compared
--expect "$GITHUB_REF_NAME"against the manifests, which would have failed oncrates-v0.1.1even once the trigger matched. It now strips the prefix, which is a no-op on a bare tag:No loop risk from the workflow writing its own trigger tag: GitHub suppresses workflow runs for refs pushed with the default
GITHUB_TOKEN. And if the tag already exists at the released commit, the tagging step no-ops rather than failing.Verification
check_versions.py --expect 0.1.1passes against the current manifestsactionlintcleanReleasing 0.1.1 now
This PR is not required to publish.
workflow_dispatchalready works today:Once this merges, re-pushing
crates-v0.1.1also works — but it has to be deleted and re-pushed, since the original push event is gone.