Conversation
| @@ -126,8 +126,6 @@ def __init__( | |||
| smagorinski_scaling_factor: float = 0.015, | |||
There was a problem hiding this comment.
wondering if we should cherry-pick the changes in config from the configuration PR #936
|
cscs-ci run default |
|
cscs-ci run distributed |
jcanton
left a comment
There was a problem hiding this comment.
for a moment I thought you had removed thhgtd_zdiffu and thslp_zdiffu from the entire codebase :-)
LGTM
|
cscs-ci run default |
|
cscs-ci run distributed |
muellch
left a comment
There was a problem hiding this comment.
I hope you did not wait for my approval,
looks good, can be merged!
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run default |
|
cscs-ci run distributed |
* main: (29 commits) Scheduled Halo Exchange (#980) Add missing metrics fields to `test_parallel_grid_manager.py` test (#1114) Muphys: Lowering with single precision (#1101) Add single-rank lsq pseudoinv factory test (#1099) Cleanup Diffusion config (#1060) Fortran bindings: fix numpy allocation and cleanups (#1112) fix: fix gt4py metrics extractor in the StencilTest benchmarking (#1111) py2fgen: don't recompile if unchanged (#1110) CI for standalone_driver (#1070) Update mpi4py and pymetis groups to make them optional (#1100) Bump mshick/add-pr-comment from 2 to 3 (#1109) Use inout fields for full_muphys as well (#1108) Update GPU configuration for graupel (#1104) Move the mask of _q_t_update outside in graupel (#1093) Update gt4py to v1.1.7 (#1105) cleanup for ugly if condition of single node default in lsq coeffs (#1103) Domain decomposition and halo construction (#540) Muphys: Add flag to wait for graupel completion (#1095) Give each gt4py program a return type hint (#1087) Turn data download off for distributed CI (#1092) ...
thslp_zdiffuandthhgtd_zdiffufrom the Fortran bindings as they are not usedhdiff_w_efdt_ratioto the Fortran bindings (though for now we don't have any experiment that deviates from the default value)