Skip to content

Cleanup Diffusion config#1060

Merged
havogt merged 9 commits intomainfrom
cleanup_diffusion_config
Mar 17, 2026
Merged

Cleanup Diffusion config#1060
havogt merged 9 commits intomainfrom
cleanup_diffusion_config

Conversation

@havogt
Copy link
Contributor

@havogt havogt commented Feb 12, 2026

  • Remove thslp_zdiffu and thhgtd_zdiffu from the Fortran bindings as they are not used
  • Add hdiff_w_efdt_ratio to the Fortran bindings (though for now we don't have any experiment that deviates from the default value)

@@ -126,8 +126,6 @@ def __init__(
smagorinski_scaling_factor: float = 0.015,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if we should cherry-pick the changes in config from the configuration PR #936

@havogt havogt mentioned this pull request Feb 12, 2026
@havogt
Copy link
Contributor Author

havogt commented Feb 18, 2026

cscs-ci run default

@havogt
Copy link
Contributor Author

havogt commented Feb 18, 2026

cscs-ci run distributed

@havogt havogt requested review from jcanton and muellch February 18, 2026 16:24
Copy link
Contributor

@jcanton jcanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for a moment I thought you had removed thhgtd_zdiffu and thslp_zdiffu from the entire codebase :-)
LGTM

@havogt
Copy link
Contributor Author

havogt commented Feb 24, 2026

cscs-ci run default

@havogt
Copy link
Contributor Author

havogt commented Feb 24, 2026

cscs-ci run distributed

Copy link
Contributor

@muellch muellch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you did not wait for my approval,
looks good, can be merged!

@github-actions
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • cscs-ci run distributed

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark-bencher

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:

  • cscs-ci run extra

For more detailed information please look at CI in the EXCLAIM universe.

@havogt
Copy link
Contributor Author

havogt commented Mar 16, 2026

cscs-ci run default

@havogt
Copy link
Contributor Author

havogt commented Mar 16, 2026

cscs-ci run distributed

@havogt havogt merged commit 351b63a into main Mar 17, 2026
54 checks passed
@havogt havogt deleted the cleanup_diffusion_config branch March 17, 2026 13:23
jcanton added a commit that referenced this pull request Mar 18, 2026
* main: (29 commits)
  Scheduled Halo Exchange (#980)
  Add missing metrics fields to `test_parallel_grid_manager.py` test (#1114)
  Muphys: Lowering with single precision (#1101)
  Add single-rank lsq pseudoinv factory test (#1099)
  Cleanup Diffusion config (#1060)
  Fortran bindings: fix numpy allocation and cleanups (#1112)
  fix: fix gt4py metrics extractor in the StencilTest benchmarking (#1111)
  py2fgen: don't recompile if unchanged (#1110)
  CI for standalone_driver (#1070)
  Update mpi4py and pymetis groups to make them optional (#1100)
  Bump mshick/add-pr-comment from 2 to 3 (#1109)
  Use inout fields for full_muphys as well (#1108)
  Update GPU configuration for graupel (#1104)
  Move the mask of _q_t_update outside in graupel (#1093)
  Update gt4py to v1.1.7 (#1105)
  cleanup for ugly if condition of single node default in lsq coeffs (#1103)
  Domain decomposition and halo construction (#540)
  Muphys: Add flag to wait for graupel completion (#1095)
  Give each gt4py program a return type hint (#1087)
  Turn data download off for distributed CI (#1092)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants