Feature: volume and mass integration utilities, prism-volume test and notebook examples - #9
Merged
Merged
Conversation
added 4 commits
July 27, 2026 10:10
…te.py Two functions are implemented, one using planar coordinates extending Suxarray nodal integration routies (`_calculate_prism_volumes`) and one leveraging a uxarray based routine (`_calculate_volumes_uxarray`). One of these two methods may be dropped at a later time. The mass calculation function (`_calculate_mass`) may also be temporary. It uses the TEOS-10 equations for calculating density and uses the gsw package.
For volume calculations, both methods `calc_volumes_from_projected` and `_calculate_volumes_uxarray` are used and their results compared.
added 2 commits
July 28, 2026 16:51
…event confusion/misapplications added TODOs for next PRs
kjnam
approved these changes
Aug 3, 2026
Member
There was a problem hiding this comment.
@aesgeorges We can leave garbage values for unused layers. Also, we do not want to integrate with zeros later. We can discuss about this later while we are moving forward with this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces new grid-integration utilities for volume and mass calculations, adds a focused synthetic unit test for prism-volume behavior, and extends the example subset notebook with end-to-end usage and comparison plots between the two volume calculation functions implemented.
What was added?
integrate.py:calc_volumes_from_projectedgswtest_volume.pyexample_subset.ipynb:gsw>=3.6dependency for density-to-mass calculations.