CO_CANsend should not increase CANtxCount if buffer is full already - #85
Merged
Conversation
…HAL_FDCAN_TxBufferCompleteCallback sends buffer only once if buffer was full).
Collaborator
|
@HamedJafarzadeh do you agree with this? |
Collaborator
|
@MaJerle I would ask @CANopenNode for comment, because this is how it is implemented in original CANOpenNode sample. |
Owner
|
This is correct and is quite important fix. I will fix CO_driver_blank.c and other projects too. However, it didn't show in my other projects: CANopenLinux doesn't use I suggest to merge. Thank you. |
CANopenNode
added a commit
to CANopenNode/CANopenNode
that referenced
this pull request
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
we had SDO Reads stall after some minutes while hammering SDO Requests with 10Hz . PDOs were still working.
Investigation in SDO-Server turned out that
CANtxCountwas 1 butbufferFullwas still false.HAL_FDCAN_TxBufferCompleteCallback sends buffer only once if buffer was full, so we can do
CANtxCount++only once.MCU was STM32G473.
This took me some time. Gemini und Claude figured it out in seconds 😒
Also fixes tabs indentation.
This issues should also be fixed in CO_driver_blank.c i guess? @CANopenNode
regards Simon