chore(beta): feedback link + version stamp on Privacy (beta infra) - #15
Merged
Conversation
Beta infrastructure, not a feature. On the Privacy screen: - A "Share your thoughts" link that opens the user's default mail app via a `mailto:` (subject "BillBuffer Feedback"; body pre-fills Version and the four prompts). Client-only — the app sends nothing, stores nothing, no network. - The current version/build (package.json version + git short SHA), stamped at build time via Vite `define`, shown on-screen and in the email body so reports say which build they came from. No analytics, telemetry, backend, accounts, or tracking. The mailto builder is a pure lib module (`src/lib/feedback.ts`) with unit tests; a small e2e asserts the link + injected version on the built app. NOTE: FEEDBACK_EMAIL defaults to clif@barge2rail.com and must be confirmed before merge — it is the only value to verify. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beta infrastructure — not a feature
Prepares BillBuffer for its first external beta with two additions to the Privacy screen. No analytics, telemetry, backend, accounts, or tracking — the feedback path is a client-only
mailto:the user's own mail app opens; the app sends and stores nothing.What
mailto:with:BillBuffer FeedbackVersion:and leaves the prompts (What were you trying to do?/What happened?/What did you expect?/Anything you'd change?).Device:is left blank on purpose — the app never reads device info.package.jsonversion + git short SHA, injected at build time via Vitedefine(compile-time string, no runtime, no network). Falls back tolocalwhere git is absent.Files
src/lib/feedback.ts(new) — puremailto:builder (no browser/network deps; passes the engine-purity architecture test).src/lib/feedback.test.ts(new) — unit tests for subject/body/version/encoding.vite.config.ts—definefor__APP_VERSION__+__APP_BUILD__.src/app.d.ts— ambient declarations for the injected globals.src/routes/privacy/+page.svelte— the link + version line.e2e/privacy.spec.ts— asserts the built app's link href + injected version.FEEDBACK_EMAILinsrc/lib/feedback.tsdefaults toclif@barge2rail.com— the recipient wasn't specified. It's a one-line change; confirm or point it at the intended beta inbox (e.g. a product address).Verification (mirrors
ci.yml)npm run check— 0 errors/warningsnpm test— 135 passed (incl. newfeedback.test.ts)npm run build— adapter-static OKnpm run test:e2e— 60 passed (incl. the new feedback test; confirms the version was injected into the built app)npm run format:check— cleanNot merged — awaiting Codex review and the email confirmation.
🤖 Generated with Claude Code