Skip to content

Bump localize-me to 0.5.3 - #98

Merged
2767mr merged 1 commit into
CCDirectLink:masterfrom
L-Sherry:updates
May 20, 2020
Merged

Bump localize-me to 0.5.3#98
2767mr merged 1 commit into
CCDirectLink:masterfrom
L-Sherry:updates

Conversation

@L-Sherry

Copy link
Copy Markdown
Contributor

This adds support for localizing DLCs. And it also fixes bugs.

@L-Sherry

Copy link
Copy Markdown
Contributor Author

The build, It is failing. And it's not because of localize-me, because it also fails on master:

https://travis-ci.com/github/CCDirectLink/CCModDB/builds/166573346

@dmitmel

dmitmel commented May 18, 2020

Copy link
Copy Markdown
Member

Try rerunning npm run build. It should regenerate checksums of the offending packages.

@L-Sherry

Copy link
Copy Markdown
Contributor Author

I'll prefer not to do that until someone compares the old files and the new ones.

Especially since readable-saves is an uploaded file and not a generated archive, so there is no reason for it to change, unless you did something.

@dmitmel

dmitmel commented May 18, 2020

Copy link
Copy Markdown
Member

I changed something in readable-saves (forgot what) without updating the version, sorry about that. Let me see the differences in character swap.

@dmitmel

dmitmel commented May 18, 2020

Copy link
Copy Markdown
Member

Interesting. The build on master on my machine fails with the following error:

error:  Error: end of central directory record signature not found
    at /home/dmitmel/.local/share/Steam/steamapps/common/CrossCode/CCModDB/build/node_modules/yauzl/index.js:187:14
    at /home/dmitmel/.local/share/Steam/steamapps/common/CrossCode/CCModDB/build/node_modules/yauzl/index.js:631:5
    at Immediate.<anonymous> (/home/dmitmel/.local/share/Steam/steamapps/common/CrossCode/CCModDB/build/node_modules/fd-slicer/index.js:202:5)
    at processImmediate (internal/timers.js:456:21)

Fortunately I had the version of CharSwap with the old hash (mentioned in the logs), so I backed it up. cc @2767mr I guess. Can you please add logging?

@L-Sherry

Copy link
Copy Markdown
Contributor Author

So ? What does diffoscope says ?

@dmitmel

dmitmel commented May 18, 2020

Copy link
Copy Markdown
Member

I can't get CCModDB's script to download something and my cached archive is exactly identical to the one at CharSwap's download URL. Commits there are from 2019. Frankly, I have no idea about what had happened to it.

This adds support for localizing DLCs.  And it also fixes bugs.
@L-Sherry
L-Sherry marked this pull request as ready for review May 19, 2020 16:48
@2767mr
2767mr merged commit ca72eb4 into CCDirectLink:master May 20, 2020
This was referenced Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants