Some worrying warnings in 0.86

[cfsmp3]

We have a number of warnings building 0.86.

Some are harmless (but we should deal with them - why implicit declarations?), some definitely look not harmless at all (incompatible pointer points) and some happen in libGPAC which we just updated and that we are not going to fix directly in CCExtractor (but if someone wants to contribute to libGPAC I'm sure they'd appreciate it).

Warnings we should fix follow:

../src/lib_ccx/ccx_encoders_transcript.c: In function ‘write_cc_bitmap_as_transcript’:
../src/lib_ccx/ccx_encoders_transcript.c:45:6: warning: implicit declaration of function ‘millis_to_date’ [-Wimplicit-function-declaration]
millis_to_date(start_time + context->subs_delay, buf1, context->date_format, context->millis_separator);
^~~~~~~~~~~~~~
../src/lib_ccx/ccx_encoders_transcript.c: In function ‘write_cc_subtitle_as_transcript’:
../src/lib_ccx/ccx_encoders_transcript.c:215:5: warning: implicit declaration of function ‘mprint’ [-Wimplicit-function-declaration]
mprint("Warning:Loss of data\n");
^~~~~~
../src/lib_ccx/general_loop.c: In function ‘rcwt_loop’:
../src/lib_ccx/general_loop.c:1252:28: warning: passing argument 1 of ‘telxcc_dump_prev_page’ from incompatible pointer type
-Wincompatible-pointer-types]
telxcc_dump_prev_page(telctx,dec_sub);
^~~~~~
In file included from ../src/lib_ccx/lib_ccx.h:22:0,
from ../src/lib_ccx/general_loop.c:1:
../src/lib_ccx/teletext.h:106:6: note: expected ‘struct TeletextCtx *’ but argument is of type ‘struct Teletext *’
void telxcc_dump_prev_page(struct TeletextCtx *ctx, struct cc_subtitle *sub);
^~~~~~~~~~~~~~~~~~~~~
../src/lib_ccx/ccx_encoders_common.c: In function ‘write_subtitle_file_footer’:
../src/lib_ccx/ccx_encoders_common.c:374:4: warning: implicit declaration of function ‘write_spumux_footer’ [-Wimplicit-function-declaration]
write_spumux_footer(out);
^~~~~~~~~~~~~~~~~~~
../src/lib_ccx/ccx_encoders_common.c: In function ‘write_subtitle_file_header’:
../src/lib_ccx/ccx_encoders_common.c:528:4: warning: implicit declaration of function ‘write_spumux_header’ [-Wimplicit-function-declaration]
write_spumux_header(ctx, out);
^~~~~~~~~~~~~~~~~~~
../src/lib_ccx/ocr.c: In function ‘ocr_rect’:
../src/lib_ccx/ocr.c:762:3: warning: implicit declaration of function ‘mapclut_paletee’ [-Wimplicit-function-declaration]
mapclut_paletee(palette, alpha, (uint32_t *)rect->data[1],rect->nb_colors);
^~~~~~~~~~~~~~~
../src/lib_ccx/ccx_encoders_spupng.c: In function ‘utf8_to_utf32’:
../src/lib_ccx/ccx_encoders_spupng.c:813:9: warning: return from incompatible pointer type [-Wincompatible-pointer-types]
return string_utf32;
^~~~~~~~~~~~
In file included from ../src/lib_ccx/ffmpeg_intgr.c:1:0:
../src/lib_ccx/ffmpeg_intgr.h:17:33: warning: ‘struct lib_ccx_ctx’ declared inside parameter list will not be visible outside
of this definition or declaration
int ffmpeg_get_more_data(struct lib_ccx_ctx *ctx, struct demuxer_data **ppdata);
^~~~~~~~~~~

[MatejMecka]

I still get compiler warnings when doing ./build on linux

../src/gpacmp4/color.c: In function 'gf_color_write_yv12_10_to_yuv':
../src/gpacmp4/color.c:2311:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2315:14: note: in expansion of macro 'GFINTCAST'
          && (GFINTCAST (vs_dst->video_buffer + vs_dst->pitch_y)%8 == 0)
              ^
../src/gpacmp4/color.c:2311:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2316:14: note: in expansion of macro 'GFINTCAST'
          && (GFINTCAST (vs_dst->video_buffer + vs_dst->pitch_y * vs_dst->height + vs_dst->pitch_y/2)%8 == 0)
              ^
../src/gpacmp4/color.c:2311:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2317:14: note: in expansion of macro 'GFINTCAST'
          && (GFINTCAST (pU + src_stride/2)%8 == 0)
              ^
../src/gpacmp4/color.c:2311:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2318:14: note: in expansion of macro 'GFINTCAST'
          && (GFINTCAST (pV + src_stride/2)%8 == 0)
              ^
../src/gpacmp4/color.c: In function 'gf_color_write_yuv422_10_to_yuv422':
../src/gpacmp4/color.c:2401:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2405:14: note: in expansion of macro 'GFINTCAST'
          && (GFINTCAST (vs_dst->video_buffer + vs_dst->pitch_y)%8 == 0)
              ^
../src/gpacmp4/color.c:2401:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2406:14: note: in expansion of macro 'GFINTCAST'
          && (GFINTCAST (vs_dst->video_buffer + vs_dst->pitch_y * vs_dst->height + vs_dst->pitch_y/2)%8 == 0)
              ^
../src/gpacmp4/color.c:2401:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2407:14: note: in expansion of macro 'GFINTCAST'
          && (GFINTCAST (pU + src_stride/2)%8 == 0)
              ^
../src/gpacmp4/color.c:2401:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2408:14: note: in expansion of macro 'GFINTCAST'
          && (GFINTCAST (pV + src_stride/2)%8 == 0)
              ^
../src/gpacmp4/color.c: In function 'gf_color_write_yuv444_10_to_yuv444':
../src/gpacmp4/color.c:2484:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2488:14: note: in expansion of macro 'GFINTCAST'
          && (GFINTCAST (vs_dst->video_buffer + vs_dst->pitch_y)%8 == 0)
              ^
../src/gpacmp4/color.c:2484:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2489:14: note: in expansion of macro 'GFINTCAST'
          && (GFINTCAST (vs_dst->video_buffer + vs_dst->pitch_y * vs_dst->height + vs_dst->pitch_y)%8 == 0)
              ^
../src/gpacmp4/color.c:2484:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2490:14: note: in expansion of macro 'GFINTCAST'
          && (GFINTCAST (pU + src_stride)%8 == 0)
              ^
../src/gpacmp4/color.c:2484:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2491:14: note: in expansion of macro 'GFINTCAST'
          && (GFINTCAST (pV + src_stride)%8 == 0)
              ^
../src/gpacmp4/color.c: In function 'gf_color_write_yuv422_10_to_yuv':
../src/gpacmp4/color.c:2567:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2571:7: note: in expansion of macro 'GFINTCAST'
   && (GFINTCAST(vs_dst->video_buffer + vs_dst->pitch_y) % 8 == 0)
       ^
../src/gpacmp4/color.c:2567:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2572:7: note: in expansion of macro 'GFINTCAST'
   && (GFINTCAST(vs_dst->video_buffer + vs_dst->pitch_y * vs_dst->height + vs_dst->pitch_y / 2) % 8 == 0)
       ^
../src/gpacmp4/color.c:2567:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2573:7: note: in expansion of macro 'GFINTCAST'
   && (GFINTCAST(pU + src_stride / 2) % 8 == 0)
       ^
../src/gpacmp4/color.c:2567:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2574:7: note: in expansion of macro 'GFINTCAST'
   && (GFINTCAST(pV + src_stride / 2) % 8 == 0)
       ^
../src/gpacmp4/color.c: In function 'gf_color_write_yuv444_10_to_yuv':
../src/gpacmp4/color.c:2658:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2662:7: note: in expansion of macro 'GFINTCAST'
   && (GFINTCAST(vs_dst->video_buffer + vs_dst->pitch_y) % 8 == 0)
       ^
../src/gpacmp4/color.c:2658:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2663:7: note: in expansion of macro 'GFINTCAST'
   && (GFINTCAST(vs_dst->video_buffer + vs_dst->pitch_y * vs_dst->height + vs_dst->pitch_y) % 8 == 0)
       ^
../src/gpacmp4/color.c:2658:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2664:7: note: in expansion of macro 'GFINTCAST'
   && (GFINTCAST(pU + src_stride) % 8 == 0)
       ^
../src/gpacmp4/color.c:2658:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GFINTCAST  (u32)
                    ^
../src/gpacmp4/color.c:2665:7: note: in expansion of macro 'GFINTCAST'
   && (GFINTCAST(pV + src_stride) % 8 == 0)
       ^
../src/gpacmp4/isom_write.c: In function 'gf_isom_set_media_language':
../src/gpacmp4/isom_write.c:261:14: warning: implicit declaration of function 'gf_lang_find' [-Wimplicit-function-declaration]
   lang_idx = gf_lang_find(code);
              ^
../src/gpacmp4/isom_write.c:266:15: warning: implicit declaration of function 'gf_lang_get_3cc' [-Wimplicit-function-declaration]
    code_3cc = gf_lang_get_3cc(lang_idx);
               ^
../src/gpacmp4/isom_write.c:266:13: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
    code_3cc = gf_lang_get_3cc(lang_idx);

[cfsmp3]

The remaining issues are in libgpac, we don't really want to divert from them any more than necessary. So this is reasonable.