Skip to content

Conversation

@MatejMecka
Copy link
Contributor

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Updated LibPNG to 1.6.35 released on Jul 15 2018

@ccextractor-bot
Copy link
Collaborator

ccextractor-bot commented Oct 25, 2018

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 86/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@ccextractor-bot
Copy link
Collaborator

ccextractor-bot commented Oct 25, 2018

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 85/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

src/libpng/png.h Outdated
* header file (zlib.h) for an explination of the compression functions.
*/

/* Set the filtering method(s) use

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains DOS line endings: \r\n instead of only \n for each line of the file. That's why the commit looks that big.
There's more info in "dealing with line endings" github page.
There are some ways to convert them back using windows, however I would wait from someone of the project to give guidance on how to do it, whether some force commit is needed to don't bloat the history of these files.

@cfsmp3 cfsmp3 merged commit 81a00dd into CCExtractor:master Oct 26, 2018
@MatejMecka MatejMecka deleted the feat/updateLibPNG branch October 27, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants