Added troubleshooting folder#1021
Added troubleshooting folder#1021sincethestudy wants to merge 4 commits intoCCExtractor:masterfrom sincethestudy:master
Conversation
|
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Your PR breaks these cases:
Check the result page for more info. |
|
Can you try to make it an .md? That's more universally accessible on GitHub compared to PDF 👍 |
|
|
||
| With only the default build tools installed you might receive an error that looks like this when trying to build: | ||
|
|
||
|  |
There was a problem hiding this comment.
Can you write a description of the image instead of saying alt text on all of them?
|
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Your PR breaks these cases:
Check the result page for more info. |
This folder is for users to reference to or add to when an issue is found.
I added the image resources to display in the .md files
|
Please see https://github.com/CCExtractor/ccextractor/wiki/Building-CCExtractor-with-Visual-Studio and https://github.com/CCExtractor/ccextractor/wiki/Solving-build-issue-with-the-v141_xp-toolchain which I have done for GCI. I have also embedded the images in these using the proper commonmark formatting. |
anshul1912
left a comment
anshul1912
left a comment
There was a problem hiding this comment.
only information about solving v141_xp build issue in Visual Studio 2015+ is not present, that i would suggest to put in wiki.
And rest all info is redundant.
| ELSE(CMAKE_SIZEOF_VOID_P EQUAL 8) | ||
| add_definitions(-DVERSION_FILE_PRESENT -DFT2_BUILD_LIBRARY -DGPAC_DISABLE_VTT -DGPAC_DISABLE_OD_DUMP) | ||
| ENDIF(CMAKE_SIZEOF_VOID_P EQUAL 8) | ||
|
|
There was a problem hiding this comment.
Already present in code
add_definitions(-DVERSION_FILE_PRESENT -DFT2_BUILD_LIBRARY -DGPAC_DISABLE_VTT -DGPAC_DISABLE_OD_DUMP)
if(CMAKE_SIZEOF_VOID_P EQUAL 8)
add_definitions(-DGPAC_64_BITS)
endif()
|
|
||
| It should take a few moments, then say build successful: | ||
|
|
||
|  No newline at end of file |
There was a problem hiding this comment.
we already have "https://github.com/CCExtractor/ccextractor/wiki/Installation#windows" I dont think we need this info again
|
|
||
| Under optional, select the the two highlighted tools in the picture above. In the bottom right corner it will show the amount of space required for the addition, ensure you have enough space on your disk, then click Modify. If Visual Studio doesn't open up after modifying, open the ccextractor.sln again. Right click the project and click build, and this time it should be successful! | ||
|
|
||
|  No newline at end of file |
There was a problem hiding this comment.
Instead of new folder, I would suggest to put troubleshooting information to go in wiki.
6 participants
This folder is for users to reference to or add to when an issue is found.
Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
{pull request content here}