Skip to content

Conversation

@navimakarov
Copy link
Contributor

@navimakarov navimakarov commented Oct 28, 2018

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

{pull request content here}

@@ -0,0 +1,243 @@
# Compiling CCExtractor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in docs/img?


#### Here you can see two files .vcxproj(marked with blue arrows) and one .sln project(marked with a red arrow)

![alt text](img/projectFiles.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of alt text can you do a description of the image?

@canihavesomecoffee
Copy link
Member

Good remarks by Matej, can you fix those?

Open the windows/ccextractor.sln file with Visual Studio (2015 at least), and build it.
**Using Visual Studio**

#### Here you can see two files .vcxproj(marked with blue arrows) and one .sln project(marked with a red arrow)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These steps should be in normal text, not subheadings.

Open the windows/ccextractor.sln file with Visual Studio (2015 at least), and build it.
**Using Visual Studio**

#### Here you can see two files .vcxproj(marked with blue arrows) and one .sln project(marked with a red arrow)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change it to something like:

Suggested change
#### Here you can see two files .vcxproj(marked with blue arrows) and one .sln project(marked with a red arrow)
Open `windows/` directory to locate `ccextractor.vcxproj`, `ccextractorGUI.vcxproj` (blue arrows) and `ccextractor.sln` (red arrow).


![alt text](img/projectFiles.png)

You have to open .sln if you want to build both non GUI and GUI ccextractor or you can build them seperately opening .vcxproj files one by one.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You have to open .sln if you want to build both non GUI and GUI ccextractor or you can build them seperately opening .vcxproj files one by one.
Using Visual Studio (2015 or above), open `ccextractor.sln`. This will build both CCExtractor and its GUI. To build them separately, open the respective `.vcxproj` file.

You have to open .sln if you want to build both non GUI and GUI ccextractor or you can build them seperately opening .vcxproj files one by one.


#### Further, if you receive a confirmation request about downloading from unsafe resource just click OK and go forward</h4>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Further, if you receive a confirmation request about downloading from unsafe resource just click OK and go forward</h4>
Accept the security prompt (if any), to proceed with compilation.



#### Further, if you receive a confirmation request about downloading from unsafe resource just click OK and go forward</h4>
![alt text](img/Warning.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace all alt text with meaningful sentences.

#### Further, if you receive a confirmation request about downloading from unsafe resource just click OK and go forward</h4>
![alt text](img/Warning.png)

#### Then if you opened .sln file you will have 2 projects on the right pannel GUI and non GUI and you can also open them separetely by opening .vcxproj files.</h4>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a redundant line, better to remove it and add tree structure in next line.

#### Then if you opened .sln file you will have 2 projects on the right pannel GUI and non GUI and you can also open them separetely by opening .vcxproj files.</h4>


#### Also there are 2 parameters in parentheses near each project(Visual studio version and Windows release version) you have to change them to parameters which are true for you by clicking right mouse button on project and selecting properties. You can see this on the photo.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Also there are 2 parameters in parentheses near each project(Visual studio version and Windows release version) you have to change them to parameters which are true for you by clicking right mouse button on project and selecting properties. You can see this on the photo.
In Solution Explorer, you'll see two projects with the VS version and Windows release version in parenthesis. Change them to parameters which are true for you by clicking right mouse button on project and selecting properties.


![alt text](img/Properties.png)

#### After that you can build these projects by clicking on each of them by mouse right button and selecting "build"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### After that you can build these projects by clicking on each of them by mouse right button and selecting "build"
Right click and select `build` to compile the project and generate executable file.


![alt text](img/Building.png)

#### Finally you will get your exe files in folder called debug which will be created in folder windows if you complete all points above
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Finally you will get your exe files in folder called debug which will be created in folder windows if you complete all points above
Find the executable file in `Debug` or `Release` folder, based on selected configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants