Skip to content

[IMPROVEMENT] Warn instead of Crash for Missing Final 0xFF Marker! #1032

Merged
cfsmp3 merged 8 commits intoCCExtractor:masterfrom
MatejMecka:fix/finalMarker
Nov 2, 2018
Merged

[IMPROVEMENT] Warn instead of Crash for Missing Final 0xFF Marker! #1032
cfsmp3 merged 8 commits intoCCExtractor:masterfrom
MatejMecka:fix/finalMarker

Conversation

@MatejMecka
Copy link
Copy Markdown
Contributor

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

The User reported issues with Extracting the file due to fatals! Instead of Crashing with @cfsmp3 decided to warn since those things can happen due to a bad stream! Replaced the fatal with mprint

@ccextractor-bot
Copy link
Copy Markdown
Collaborator

ccextractor-bot commented Oct 31, 2018

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 86/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@ccextractor-bot
Copy link
Copy Markdown
Collaborator

ccextractor-bot commented Oct 31, 2018

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 82/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

Comment thread docs/CHANGES.TXT Outdated
Co-Authored-By: MatejMecka <matej.plavevski+github@gmail.com>
@cfsmp3 cfsmp3 merged commit 1807ea9 into CCExtractor:master Nov 2, 2018
@MatejMecka MatejMecka deleted the fix/finalMarker branch December 3, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants