[IMPROVEMENT] Warn instead of Crash for Missing Final 0xFF Marker! #1032
Merged
cfsmp3 merged 8 commits intoCCExtractor:masterfrom Nov 2, 2018
MatejMecka:fix/finalMarker
Merged
[IMPROVEMENT] Warn instead of Crash for Missing Final 0xFF Marker! #1032cfsmp3 merged 8 commits intoCCExtractor:masterfrom MatejMecka:fix/finalMarker
cfsmp3 merged 8 commits intoCCExtractor:masterfrom
MatejMecka:fix/finalMarker
Conversation
Collaborator
|
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Your PR breaks these cases:
Check the result page for more info. |
Collaborator
|
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Your PR breaks these cases:
Check the result page for more info. |
saurabhshri
reviewed
Nov 1, 2018
Co-Authored-By: MatejMecka <matej.plavevski+github@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
The User reported issues with Extracting the file due to fatals! Instead of Crashing with @cfsmp3 decided to warn since those things can happen due to a bad stream! Replaced the fatal with mprint