Skip to content

Add support for 4.0 tesseract#1038

Merged
anshul1912 merged 1 commit intoCCExtractor:masterfrom
anshul1912:master
Nov 7, 2018
Merged

Add support for 4.0 tesseract#1038
anshul1912 merged 1 commit intoCCExtractor:masterfrom
anshul1912:master

Conversation

@anshul1912
Copy link
Copy Markdown
Contributor

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Add support for 4.0 tesseract

@ccextractor-bot
Copy link
Copy Markdown
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 86/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@ccextractor-bot
Copy link
Copy Markdown
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 14/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 80/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@anshul1912 anshul1912 merged commit 38fc6e5 into CCExtractor:master Nov 7, 2018
Copy link
Copy Markdown
Contributor

@Abhinav95 Abhinav95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rboy1
Copy link
Copy Markdown
Contributor

rboy1 commented Jan 25, 2019

Does this mean that older versions of Tesseract won't work and only v4.0 will be supported?

@anshul1912
Copy link
Copy Markdown
Contributor Author

No older is also supported based on makefile defines

@rboy1
Copy link
Copy Markdown
Contributor

rboy1 commented Jan 27, 2019

So for clarity it would be nice to include all the supported versions in the changelog or in the how to use OCR page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants