[FIX] Added support for font colors and italics #1132
Conversation
|
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Your PR breaks these cases:
Check the result page for more info. |
|
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Your PR breaks these cases:
Check the result page for more info. |
src/lib_ccx/ccx_encoders_spupng.c
Outdated
| if (FT_Load_Char(face, current_char_code, FT_LOAD_RENDER)) continue; // ignore errors | ||
| // Parse tags like <i> and <b> | ||
| if (end) { | ||
| if (current_char_code == '>') { |
There was a problem hiding this comment.
It seems to me that if we meet tags like <b><i>test</i> test2</b> (if that is valid), it would output "test test2" instead of "test test2"
src/lib_ccx/ccx_encoders_spupng.c
Outdated
| continue; | ||
| } | ||
|
|
||
| slot = current_face->glyph; |
There was a problem hiding this comment.
I think it might be better and easier to decide which typeface to use here based on the value of italics and bold, instead of changing current_face in ifs.
|
So I took a quick look at 608 decoder and it seems that |
Please check the decoders, but as far as I am aware that is all. |
jshin313
force-pushed
the
handle_tags
branch
from
e84c37a to
29c0cb8
Compare
|
I added support for color. I couldn't find a video sample that wanted different font colors in the captions so I just put the following in the spupng_export_string2png function:
I get the follow output from testing the program with the above string. |
jshin313
force-pushed
the
handle_tags
branch
2 times, most recently
from
89e96ae to
29c0cb8
Compare
cfsmp3
left a comment
cfsmp3
left a comment
There was a problem hiding this comment.
This PR changes a lot of things (formatting) that are unrelated to the functionality it claims to add, making it difficult to review.
Please don't change someone else's formatting (when we do this, it's a PR that does that just and nothing else).
Instead, send a smaller PR that does exactly what it says it does and nothing else.
|
Are you referring to the changes in the functions' parameters and addition changes to the functions' code when you say formatting or do you mean like spaces and tabs. Can you clarify what you mean by formatting. Thanks for reviewing my code. |
|
Also I still have to add support for underlining. |
jshin313
changed the title
4 participants
Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
The pull request addresses the issue linked here as part of a Google Code-in task. Thus, expect less than optimal code from a high school student. The changes were tested on a Windows 10 machine using Visual Studio 2019 to build ccextractor.