Skip to content

Conversation

@eshandhawan51
Copy link
Contributor

@eshandhawan51 eshandhawan51 commented Jan 1, 2020

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • [ 1 ] I have read and understood the contributors guide.
  • [1] I have checked that another pull request for this purpose does not exist.
  • [1] I have considered, and confirmed that this submission will be valuable to others.
  • [1] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • [1] I give this submission freely, and claim no ownership to its content.
  • [0] I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • [1] I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

{pull request content here}
the pull request solves issue #1131 having invalid free problem

@ccextractor-bot
Copy link
Collaborator

ccextractor-bot commented Jan 1, 2020

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 14/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 86/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@ccextractor-bot
Copy link
Collaborator

ccextractor-bot commented Jan 2, 2020

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 2/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 20/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@NilsIrl
Copy link
Contributor

NilsIrl commented Jan 2, 2020

There is a freep function made especially for that

Copy link
Contributor

@NilsIrl NilsIrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another way of doing it

statement to free pointer

Co-Authored-By: Nils ANDRÉ-CHANG <nils@nilsand.re>
@cfsmp3 cfsmp3 merged commit bba6c4f into CCExtractor:master Jan 2, 2020
@NilsIrl
Copy link
Contributor

NilsIrl commented Jan 2, 2020

With freep you don't have to null the pointer, as freep does it for you. Sorry I'm not very good with github reviews.

@NilsIrl
Copy link
Contributor

NilsIrl commented Jan 2, 2020

Opened #1171 for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants