Skip to content

[IMPROVEMENT] Add Cmake job to github action #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
canihavesomecoffee merged 2 commits into from
Jan 18, 2020
Merged

[IMPROVEMENT] Add Cmake job to github action #1193

canihavesomecoffee merged 2 commits into from
Jan 18, 2020

Conversation

@NilsIrl
Copy link
Contributor

@NilsIrl NilsIrl commented Jan 18, 2020

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have used CCExtractor just a couple of times.

@NilsIrl NilsIrl force-pushed the cmake_github_action branch from d6f1147 to ab1af7c Compare January 18, 2020 20:16
@NilsIrl
Copy link
Contributor Author

NilsIrl commented Jan 18, 2020

did it just build in 35 seconds?

@NilsIrl
Copy link
Contributor Author

NilsIrl commented Jan 18, 2020

I'm not sure if adding -j$(nproc) is the correct way to parallelize.

@canihavesomecoffee
Copy link
Member

canihavesomecoffee commented Jan 18, 2020

I'm not sure if adding -j$(nproc) is the correct way to parallelize.

I see it being used in quite some other projects, so lgtm.

@canihavesomecoffee canihavesomecoffee merged commit 54ecce8 into CCExtractor:master Jan 18, 2020
@NilsIrl
Copy link
Contributor Author

NilsIrl commented Jan 18, 2020

I see it being used in quite some other projects, so lgtm.

I was thinking within a github action environment.

@ccextractor-bot
Copy link
Collaborator

ccextractor-bot commented Jan 18, 2020

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 3/13
DVB 5/7
DVR-MS 0/2
General 1/27
Hauppage 0/3
MP4 0/3
NoCC 10/10
Teletext 20/21
WTV 0/13
XDS 0/34
CEA-708 6/14
DVD 0/3
Options 9/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@NilsIrl NilsIrl deleted the cmake_github_action branch January 21, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@canihavesomecoffee canihavesomecoffee canihavesomecoffee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NilsIrl @canihavesomecoffee @ccextractor-bot