[IMPROVEMENT] Add SCC color output support#1213
Conversation
|
Updated this as well, though it probably shouldn't be merged yet due to the lack of player testing. |
|
Use youtube as a testing ground since they support SCC. |
|
The person who requested SCC (and CCD) sent a file with colors. Either in the original implementation PR or in the issue. |
|
#1120 (comment) (please keep in mind that the output shouldn't be exactly the same as the input files had redundant control codes) |
|
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Your PR breaks these cases:
Check the result page for more info. |
|
I'm aware of the examples, I used those to test and compare the output. The problem is that I can't find an SCC player which supports color — YouTube and MPV appear to only support white. VLC was able to display color when decoding the original EIA-608 data, but I can't get it to load any SCC files. |
|
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Your PR breaks these cases:
Check the result page for more info. |
|
Rebased. |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
This adds support for all colors defined here, as well as their italic variants. Note that I have not tested the output because MPV doesn't appear to support SCC colors, VLC freezes while trying to open any SCC file, and I haven't been able to find any other players that support SCC. It looks fine with a visual comparison to the examples from #1120, but an actual test would be nice to have before merging.