Skip to content

[IMPROVEMENT] Add SCC color output support#1213

Merged
cfsmp3 merged 1 commit intoCCExtractor:masterfrom
kdrag0n:scc-colors
Jan 26, 2020
Merged

[IMPROVEMENT] Add SCC color output support#1213
cfsmp3 merged 1 commit intoCCExtractor:masterfrom
kdrag0n:scc-colors

Conversation

@kdrag0n
Copy link
Contributor

@kdrag0n kdrag0n commented Jan 23, 2020

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have used CCExtractor just a couple of times.

This adds support for all colors defined here, as well as their italic variants. Note that I have not tested the output because MPV doesn't appear to support SCC colors, VLC freezes while trying to open any SCC file, and I haven't been able to find any other players that support SCC. It looks fine with a visual comparison to the examples from #1120, but an actual test would be nice to have before merging.

@kdrag0n
Copy link
Contributor Author

kdrag0n commented Jan 23, 2020

Updated this as well, though it probably shouldn't be merged yet due to the lack of player testing.

@cfsmp3
Copy link
Contributor

cfsmp3 commented Jan 23, 2020

Use youtube as a testing ground since they support SCC.

@NilsIrl
Copy link
Contributor

NilsIrl commented Jan 23, 2020

The person who requested SCC (and CCD) sent a file with colors. Either in the original implementation PR or in the issue.

@NilsIrl
Copy link
Contributor

NilsIrl commented Jan 23, 2020

#1120 (comment) (please keep in mind that the output shouldn't be exactly the same as the input files had redundant control codes)

@ccextractor-bot
Copy link
Collaborator

ccextractor-bot commented Jan 23, 2020

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 15/21
WTV 12/13
XDS 33/34
CEA-708 14/14
DVD 3/3
Options 82/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@kdrag0n
Copy link
Contributor Author

kdrag0n commented Jan 23, 2020

I'm aware of the examples, I used those to test and compare the output. The problem is that I can't find an SCC player which supports color — YouTube and MPV appear to only support white. VLC was able to display color when decoding the original EIA-608 data, but I can't get it to load any SCC files.

@ccextractor-bot
Copy link
Collaborator

ccextractor-bot commented Jan 23, 2020

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 33/34
CEA-708 14/14
DVD 3/3
Options 85/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@kdrag0n
Copy link
Contributor Author

kdrag0n commented Jan 25, 2020

Rebased.

@cfsmp3 cfsmp3 merged commit 0afba56 into CCExtractor:master Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants