Skip to content

Update ccx_encoders_common.c#1256

Closed
vasil-bonev wants to merge 1 commit intoCCExtractor:masterfrom
jakubvojacek:master
Closed

Update ccx_encoders_common.c#1256
vasil-bonev wants to merge 1 commit intoCCExtractor:masterfrom
jakubvojacek:master

Conversation

@vasil-bonev
Copy link
Copy Markdown

In raising this pull request, I confirm the following (please check boxes):

  • [*] I have read and understood the contributors guide.
  • [*] I have checked that another pull request for this purpose does not exist.
  • [*] I have considered, and confirmed that this submission will be valuable to others.
  • [*] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • [*] I give this submission freely, and claim no ownership to its content.
  • [*] I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • [* ] I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Hello,
I would ask about your python solution found here:

"jakubvojacek commented on 20 Jul 2018
I got it working (not in ccextractor but using a small python script). Already got over 100 channels with subtitles working and seems to be quite stable."

Im facing the same problem with live webvtt subs extraction and packaging after with Shaka.
Would be appreciated, for your help.

Regards:
Vasil Bonev
vasil.bonev72@gmail.com

{pull request content here}

@cfsmp3
Copy link
Copy Markdown
Contributor

cfsmp3 commented Apr 21, 2020

@vasil-bonev Can you comment on the reason for removing the STYLE?
Also, looks like it can't be merged even if it's a one liner, so maybe you're working off an old version and this is not needed at all?

@canihavesomecoffee
Copy link
Copy Markdown
Member

@cfsmp3 It's not a real PR afaik, but more of a question. Read the comment above...

@cfsmp3 cfsmp3 closed this Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants