Skip to content

remove default BOM from windows#1383

Merged
cfsmp3 merged 2 commits intoCCExtractor:masterfrom
PunitLodha:bom
Oct 8, 2021
Merged

remove default BOM from windows#1383
cfsmp3 merged 2 commits intoCCExtractor:masterfrom
PunitLodha:bom

Conversation

@PunitLodha
Copy link
Member

@PunitLodha PunitLodha commented Oct 5, 2021

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

BOM is no longer enabled by default on windows

@cfsmp3 cfsmp3 self-requested a review October 5, 2021 21:54
Copy link
Contributor

@cfsmp3 cfsmp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

params.c needs to be updated (it says that -bom is the default for Windows, which is no longer true)
CHANGES.TXT needs to be updated

@PunitLodha PunitLodha requested a review from cfsmp3 October 8, 2021 17:11
@cfsmp3 cfsmp3 merged commit 50aceb4 into CCExtractor:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants