Attempt to improve mp4 detection#148
Merged
cfsmp3 merged 1 commit intoCCExtractor:masterfrom Apr 8, 2015
Merged
Conversation
added 'wide' box to mp4 detection algorithm
hrideshmg
pushed a commit
to hrideshmg/ccextractor
that referenced
this pull request
Mar 12, 2025
Adds an initial version of the build badges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is based on gpacs' mp4 detecition "gf_isom_probe_file" function
there was a typo in mp4 detection algorithm 'feee'->'free'
I had also added 'wide' box to mp4 detection algorithm, because it could also appear in the beginning of the file
I haven't found any description of 'jP ' box, so it was not included in this fix
Hope this fix will slightly increase true positive rate of mp4 detection.