[IMPROVEMENT] getting rid of the warnings during rust builds#1497
Merged
PunitLodha merged 1 commit intoCCExtractor:masterfrom Mar 15, 2023
Merged
Conversation
Contributor
Author
|
Hi @cfsmp3 ! Could you check this out? It's just a minor quality of life fix and gets rid of the Rust warnings. |
Contributor
|
I assigned the review to @PunitLodha , he's been doing the Rust side of things around here :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
#1469 brought this up where we would get some warnings when compiling the rust module without the
hardsubx_ocrfeature. As stated later in the issue thesemuts are actually necessary when the feature is turned on. This fix is a minor change which removes the warnings in both the cases. This might allow us to maybe useRUSTFLAGS="--deny warnings"in our workflows to fail on warnings.