Skip to content

[IMPROVEMENT] getting rid of the warnings during rust builds#1497

Merged
PunitLodha merged 1 commit intoCCExtractor:masterfrom
ArchitBhonsle:remove-rust-build-warnings
Mar 15, 2023
Merged

[IMPROVEMENT] getting rid of the warnings during rust builds#1497
PunitLodha merged 1 commit intoCCExtractor:masterfrom
ArchitBhonsle:remove-rust-build-warnings

Conversation

@ArchitBhonsle
Copy link
Copy Markdown
Contributor

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

#1469 brought this up where we would get some warnings when compiling the rust module without the hardsubx_ocr feature. As stated later in the issue these muts are actually necessary when the feature is turned on. This fix is a minor change which removes the warnings in both the cases. This might allow us to maybe use RUSTFLAGS="--deny warnings" in our workflows to fail on warnings.

@cfsmp3 cfsmp3 requested a review from PunitLodha March 14, 2023 18:26
@ArchitBhonsle
Copy link
Copy Markdown
Contributor Author

Hi @cfsmp3 ! Could you check this out? It's just a minor quality of life fix and gets rid of the Rust warnings.

@cfsmp3
Copy link
Copy Markdown
Contributor

cfsmp3 commented Mar 15, 2023

I assigned the review to @PunitLodha , he's been doing the Rust side of things around here :-)

Copy link
Copy Markdown
Member

@PunitLodha PunitLodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@PunitLodha PunitLodha merged commit cb496a7 into CCExtractor:master Mar 15, 2023
@ArchitBhonsle ArchitBhonsle deleted the remove-rust-build-warnings branch April 3, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants