[FIX] ccx_encoders_smptett.c: Enforce int for sprintf #1506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors formatting of `col1` and `row1` variables to avoid issues with LC_NUMERIC autoformatting float values
Collaborator
|
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Your PR breaks these cases:
Check the result page for more info. |
cfsmp3
reviewed
Mar 20, 2023
src/lib_ccx/ccx_encoders_smptett.c
Outdated
| // COLUMNS is actually 90% of the screen size | ||
| // Add +10% because column 0 is at position 10% | ||
| col1 = ((100 * firstcol) / (COLUMNS / 0.8)) + 10; | ||
| col1_int = col1; |
Contributor
There was a problem hiding this comment.
This is going to trigger a compiler warning about loss of precision. i.e. use casting.
Author
There was a problem hiding this comment.
Ah I see, my bad. I was also considering using a function like modf but I wanted to only use arithmetic if possible. Let me try something else.
cfsmp3
reviewed
Mar 20, 2023
TTML specifications make no recommendation regarding decimal places for tts:origin values. Tests were done on video and no discernable difference was observed.
Collaborator
|
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Your PR breaks these cases:
Check the result page for more info. |
cfsmp3
requested changes
Mar 20, 2023
Contributor
cfsmp3
left a comment
cfsmp3
left a comment
There was a problem hiding this comment.
We really don't need to use a math function to convert from a float to an int :-) (losing the fractional part). A cast will do.
I'm not sure we are OK with that unneeded lost of precision though. I'd very much prefer to keep 2 or 3 decimal places.
Author
Ah 😅 well, in that case, I'll aim for two! |
Will return integer and fractional parts of the floats, but no longer requires 3 decimal places at all times, can show less, but 1 at minimum.
Contributor
|
Please make sure you test a bit before sending or updating a PR. Your code won't work for example for 3.099 Reopen the PR (or start a new one) only after you have tested with many values. Thanks! |
Author
Got it, I'll work on this more~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
For issue #1483, refactors formatting of
col1androw1variables to avoid issues with LC_NUMERIC auto-formatting float values.