Cleanup vs configs#1539
Merged
canihavesomecoffee merged 7 commits intoCCExtractor:masterfrom May 29, 2023
Merged
Conversation
cfsmp3
approved these changes
May 22, 2023
Contributor
cfsmp3
left a comment
There was a problem hiding this comment.
Some spring cleaning is always nice
cfsmp3
approved these changes
May 22, 2023
Contributor
cfsmp3
left a comment
There was a problem hiding this comment.
Some spring cleaning is always nice
PunitLodha
approved these changes
May 22, 2023
Member
PunitLodha
left a comment
There was a problem hiding this comment.
You could also remove windows/rustx86.bat, as its not being used anymore
d59d8db to
49696bb
Compare
Member
|
@canihavesomecoffee is there any blocker for this PR, if not why haven't it been merged already? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Reduces the amount of VS configs to 2 (64 bit OCR enabled debug and release), cleans up the Nuklear GUI from the repo, build Rust in the correct mode (release or debug) depending on the build.