Skip to content

Cleanup vs configs#1539

Merged
canihavesomecoffee merged 7 commits intoCCExtractor:masterfrom
canihavesomecoffee:cleanup-vs-configs
May 29, 2023
Merged

Cleanup vs configs#1539
canihavesomecoffee merged 7 commits intoCCExtractor:masterfrom
canihavesomecoffee:cleanup-vs-configs

Conversation

@canihavesomecoffee
Copy link
Copy Markdown
Member

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Reduces the amount of VS configs to 2 (64 bit OCR enabled debug and release), cleans up the Nuklear GUI from the repo, build Rust in the correct mode (release or debug) depending on the build.

Copy link
Copy Markdown
Contributor

@cfsmp3 cfsmp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some spring cleaning is always nice

Copy link
Copy Markdown
Contributor

@cfsmp3 cfsmp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some spring cleaning is always nice

Copy link
Copy Markdown
Member

@PunitLodha PunitLodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also remove windows/rustx86.bat, as its not being used anymore

@prateekmedia
Copy link
Copy Markdown
Member

@canihavesomecoffee is there any blocker for this PR, if not why haven't it been merged already?

@canihavesomecoffee canihavesomecoffee merged commit 5b76669 into CCExtractor:master May 29, 2023
@canihavesomecoffee canihavesomecoffee deleted the cleanup-vs-configs branch May 29, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants