fix(rust): remove unused assignments in tv_screen.rs#1795
Merged
Conversation
Remove three unused assignments to `time_show.time_in_ms` that were flagged by Clippy as "value assigned is never read". The pattern was: subtract frame delay, use the value, then restore it. However, since `time_show` is not used after the match statement, the restoration assignments were unnecessary dead code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove three unused assignments to
time_show.time_in_msinsrc/rust/src/decoder/tv_screen.rsthat were flagged by Clippy as "value assigned is never read".Issue
Clippy reported warnings:
Root Cause
The code pattern was:
time_show.time_in_msget_scc_time_str(time_show)However, since
time_showis not used after the match statement ends, the restoration assignments (step 3) were unnecessary dead code.Changes
Removed the three unnecessary
+= 1000 / 29.97 as i64assignments at the end of each match branch.Test plan
🤖 Generated with Claude Code