fix(mcc_encoder): prevent buffer overruns and add OOM checks #1804

cfsmp3 · 2025-12-13T00:10:43Z

Summary

This PR fixes multiple buffer overrun vulnerabilities and missing out-of-memory (OOM) checks in the MCC (MacCaption) encoder in src/lib_ccx/ccx_encoders_mcc.c.

Issues Found and Fixed

1. Missing OOM Checks (2 instances)

Function	Variable	Risk
`mcc_encode_cc_data`	`compressed_data_buffer`	NULL dereference in sprintf/strcat
`add_boilerplate`	`buff_ptr`	NULL dereference in array assignments

Fix: Added fatal(EXIT_NOT_ENOUGH_MEMORY, ...) checks after each allocation.

2. Unsafe `sprintf` Calls (12 instances)

All sprintf calls into fixed-size buffers were replaced with snprintf:

Function	Buffer	Original Size	New Size
`mcc_encode_cc_data`	`compressed_data_buffer`	dynamic	dynamic (with size tracking)
`generate_mcc_header`	`uuid_str`	50	50
`generate_mcc_header`	`date_str`	50	64
`generate_mcc_header`	`time_str`	30	32
`generate_mcc_header`	`tcr_str` (7 locations)	25	32

3. Unsafe `strcat` Call

Before:

strcat(compressed_data_buffer, "\n");

After:

size_t current_len = strlen(compressed_data_buffer);
if (current_len + 1 < compressed_data_size)
{
    compressed_data_buffer[current_len] = '\n';
    compressed_data_buffer[current_len + 1] = '\0';
}

4. Unsafe `vsprintf` in `debug_log`

Before:

char message[1024];
vsprintf(message, fmt, args);

After:

char message[1024];
vsnprintf(message, sizeof(message), fmt, args);

5. Inefficient `sprintf` Loop in `random_chars`

Before:

for (int i = 0; i < len; i++)
{
    sprintf(buffer + i, "%X", rand() % 16);  // Writes 2 bytes per iteration (char + null)
}

After:

static const char hex_chars[] = "0123456789ABCDEF";
for (int i = 0; i < len; i++)
{
    buffer[i] = hex_chars[rand() % 16];  // Direct assignment, more efficient
}

6. Uninitialized Buffer in Default Case

Added tcr_str[0] = '\0'; in the default case of the framerate switch to prevent using uninitialized data.

Code Changes Summary

Metric	Before	After
`malloc()` without NULL check	2	0
`sprintf()` calls	12	0
`snprintf()` calls	0	12
`strcat()` calls	1	0
`vsprintf()` calls	1	0
`vsnprintf()` calls	0	1

Security Impact

These fixes prevent:

Null pointer dereference crashes when memory is exhausted
Stack buffer overflow via fixed-size string buffers
Heap buffer overflow via dynamically allocated buffers
Use of uninitialized data in edge cases

MCC output is used for professional broadcast captioning, making reliability important.

Test Plan

Code compiles without warnings from ccx_encoders_mcc.c
Build completes successfully
Test MCC output generation with sample files
Verify header format is correct (UUID, date, time code rate)

🤖 Generated with Claude Code

- Add NULL checks after malloc calls for compressed_data_buffer and buff_ptr - Replace sprintf with snprintf for all string formatting operations - Replace strcat with bounds-checked direct character assignment - Replace vsprintf with vsnprintf in debug_log function - Replace sprintf loop in random_chars with direct character lookup table - Increase buffer sizes for date_str (50->64), time_str (30->32), tcr_str (25->32) - Initialize tcr_str in default case to prevent uninitialized use - Add lib_ccx.h include for fatal() function declaration Functions modified: - mcc_encode_cc_data: OOM check + sprintf -> snprintf + strcat -> direct assignment - generate_mcc_header: sprintf -> snprintf for uuid_str, date_str, time_str, tcr_str - add_boilerplate: OOM check for buff_ptr - random_chars: sprintf -> direct character lookup (more efficient) - debug_log: vsprintf -> vsnprintf + safer strlen check 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

ccextractor-bot · 2025-12-13T06:12:22Z

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 77e1dff...:

Report Name	Tests Passed
Broken	13/13
CEA-708	14/14
DVB	7/7
DVD	3/3
DVR-MS	2/2
General	27/27
Hardsubx	1/1
Hauppage	3/3
MP4	3/3
NoCC	10/10
Options	86/86
Teletext	21/21
WTV	13/13
XDS	34/34

Congratulations: Merging this PR would fix the following tests:

ccextractor --autoprogram --out=srt --latin1 1d9731bd80..., Last passed: Never
ccextractor --out=srt --latin1 --autoprogram 73d9313d64..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 8e8229b88b..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 7236304cfc..., Last passed: Never
ccextractor --out=ttxt --latin1 001dd8cdf7..., Last passed: Never
ccextractor --out=srt --latin1 06b3a9237d..., Last passed: Never
ccextractor --out=srt --latin1 83f8cceb74..., Last passed: Never
ccextractor --out=srt --latin1 611b4a9235..., Last passed: Never
ccextractor --out=srt --latin1 b46e9e8e3f..., Last passed: Never
ccextractor --out=srt --latin1 89e417e622..., Last passed: Never
ccextractor --out=srt --latin1 d59eadc4ed..., Last passed: Never
ccextractor --out=srt --latin1 4d4e938ef6..., Last passed: Never
ccextractor --out=sami --latin1 --autoprogram --no-goptime 5b4e0a6034..., Last passed: Never
ccextractor --service 1 --out=txt --no-bom --no-rollup ea83ff7bcb..., Last passed: Never
ccextractor --service 1 --out=txt f17524b53f..., Last passed: Never
ccextractor --service 1 --out=txt da904de35d..., Last passed: Never
ccextractor --service 1 --out=txt 80848c45f8..., Last passed: Never
ccextractor --service 1 --out=txt --no-bom --no-rollup b5d6aad89f..., Last passed: Never
ccextractor --service 1[EUC-KR] --out=txt --no-rollup b5d6aad89f..., Last passed: Never
ccextractor --service 1 --out=srt da904de35d..., Last passed: Never
ccextractor --service 1 --out=sami da904de35d..., Last passed: Never
ccextractor --service 1 --out=ttxt da904de35d..., Last passed: Never
ccextractor --service 1[EUC-KR] b5d6aad89f..., Last passed: Never
ccextractor --service 1[EUC-KR] --no-rollup b5d6aad89f..., Last passed: Never
ccextractor --service all da904de35d..., Last passed: Never
ccextractor --service all[EUC-KR] b5d6aad89f..., Last passed: Never
ccextractor --service 1,2[UTF-8],3[EUC-KR],54 --out=txt da904de35d..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 1020459a86..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 f1422b8bfe..., Last passed: Never
ccextractor --datapid 5603 --autoprogram --out=srt --latin1 --teletext 85c7fc1ad7..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 d41b53b504..., Last passed: Never
ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed: Never
ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --quant 0 85271be4d2..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 5ae2007a79..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 1e44efd810..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 add511677c..., Last passed: Never
ccextractor --wtvconvertfix --autoprogram --out=srt --latin1 acf871cbfd..., Last passed: Never
ccextractor --wtvconvertfix --autoprogram --out=srt --latin1 5cbb21adb6..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 9a496d3828..., Last passed: Never
ccextractor --out=srt --latin1 --autoprogram 56c9f34548..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 e9b9008fdf..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 c032183ef0..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 27e46255f0..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 d037c7509e..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 1974a299f0..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 132d7df7e9..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 99e5eaafdc..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 b22260d065..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla 7aad20907e..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla c41f73056a..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla 5d3a29f9f8..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla 70000200c0..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla 6dc772d881..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla adce82fd39..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla 15feae9133..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla 95dd33c6f1..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 01509e4d27..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla ab9cf8cfad..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 15feae9133..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --output-field 2 5d3a29f9f8..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --output-field 2 c41f73056a..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --sentencecap c032183ef0..., Last passed: Never
ccextractor --autoprogram --out=bin --latin1 c032183ef0..., Last passed: Never
ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b..., Last passed: Never
ccextractor --hardsubx 1a0302f7fd..., Last passed: Never
ccextractor --hauppauge --autoprogram --out=srt --latin1 a03b5b2a56..., Last passed: Never
ccextractor --autoprogram --out=srt --hauppauge --latin1 553d78e755..., Last passed: Never
ccextractor --autoprogram --out=ttxt --hauppauge --ucla --latin1 553d78e755..., Last passed: Never
ccextractor --in=mp4 --out=srt --latin1 b2771c84c2..., Last passed: Never
ccextractor --in=mp4 --out=srt --latin1 5df914ce77..., Last passed: Never
ccextractor --autoprogram --out=srt --bom --latin1 8849331dda..., Last passed: Never
ccextractor --mp4vidtrack --autoprogram --out=ttxt --latin1 adc0a818c3..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 08bdf0e2c1..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 bee139671a..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 3842d00925..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 80af83c038..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 837b02f722..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 41dab6b2a7..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 4b117b4d66..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 26ee6add4d..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds fca0dce412..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --output-field 1 a65d39ccb3..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --output-field 2 a65d39ccb3..., Last passed: Never
ccextractor --autoprogram c83f765c66..., Last passed: Never
ccextractor --service 1 c83f765c66..., Last passed: Never
ccextractor --in=ts c83f765c66..., Last passed: Never
ccextractor --out=srt c83f765c66..., Last passed: Never
ccextractor --out=sami c83f765c66..., Last passed: Never
ccextractor --out=dvdraw c83f765c66..., Last passed: Never
ccextractor --out=txt c83f765c66..., Last passed: Never
ccextractor --out=ttxt c83f765c66..., Last passed: Never
ccextractor --out=smptett c83f765c66..., Last passed: Never
ccextractor --out=spupng c83f765c66..., Last passed: Never
ccextractor --goptime c83f765c66..., Last passed: Never
ccextractor --no-goptime c83f765c66..., Last passed: Never
ccextractor --fixpadding c83f765c66..., Last passed: Never
ccextractor --90090 c83f765c66..., Last passed: Never
ccextractor --myth c83f765c66..., Last passed: Never
ccextractor --program-number 1 c83f765c66..., Last passed: Never
ccextractor --datapid 256 c83f765c66..., Last passed: Never
ccextractor --datastreamtype 2 c83f765c66..., Last passed: Never
ccextractor --datastreamtype 2 --streamtype 2 c83f765c66..., Last passed: Never
ccextractor --no-autotimeref c83f765c66..., Last passed: Never
ccextractor --bom c83f765c66..., Last passed: Never
ccextractor --no-bom c83f765c66..., Last passed: Never
ccextractor --unicode c83f765c66..., Last passed: Never
ccextractor --utf8 c83f765c66..., Last passed: Never
ccextractor --latin1 c83f765c66..., Last passed: Never
ccextractor --no-fontcolor c83f765c66..., Last passed: Never
ccextractor --no-typesetting c83f765c66..., Last passed: Never
ccextractor --trim c83f765c66..., Last passed: Never
ccextractor --sentencecap c83f765c66..., Last passed: Never
ccextractor --capfile /repository/Dictionary/MattS_dictionary.txt c83f765c66..., Last passed: Never
ccextractor --unixts 5 --out=txt c83f765c66..., Last passed: Never
ccextractor --out=txt --datets c83f765c66..., Last passed: Never
ccextractor --out=txt --sects c83f765c66..., Last passed: Never
ccextractor --out=txt --lf c83f765c66..., Last passed: Never
ccextractor --autodash --trim c83f765c66..., Last passed: Never
ccextractor --bufferinput c83f765c66..., Last passed: Never
ccextractor --no-bufferinput c83f765c66..., Last passed: Never
ccextractor --buffersize 1M c83f765c66..., Last passed: Never
ccextractor --dru c83f765c66..., Last passed: Never
ccextractor --no-rollup c83f765c66..., Last passed: Never
ccextractor --ru1 c83f765c66..., Last passed: Never
ccextractor --ru2 c83f765c66..., Last passed: Never
ccextractor --ru3 c83f765c66..., Last passed: Never
ccextractor --delay 200 c83f765c66..., Last passed: Never
ccextractor --startat 4 --endat 7 c83f765c66..., Last passed: Never
ccextractor --no-codec dvbsub c83f765c66..., Last passed: Never
ccextractor --debug --out=srt c83f765c66..., Last passed: Never
ccextractor --608 --out=srt c83f765c66..., Last passed: Never
ccextractor --708 --out=srt c83f765c66..., Last passed: Never
ccextractor --goppts --out=srt c83f765c66..., Last passed: Never
ccextractor --xdsdebug --out=srt c83f765c66..., Last passed: Never
ccextractor --vides --out=srt c83f765c66..., Last passed: Never
ccextractor --cbraw --out=srt c83f765c66..., Last passed: Never
ccextractor --no-sync --out=srt c83f765c66..., Last passed: Never
ccextractor --fullbin --out=srt c83f765c66..., Last passed: Never
ccextractor --parsedebug --out=srt c83f765c66..., Last passed: Never
ccextractor --parsePAT --out=srt c83f765c66..., Last passed: Never
ccextractor --parsePMT --out=srt c83f765c66..., Last passed: Never
ccextractor --investigate-packets --out=srt c83f765c66..., Last passed: Never
ccextractor --in=ps e9b9008fdf..., Last passed: Never
ccextractor --in=es dc7169d7c4..., Last passed: Never
ccextractor --in=asf 6395b281ad..., Last passed: Never
ccextractor --in=wtv b46e9e8e3f..., Last passed: Never
ccextractor --in=bin 988d4e8bba..., Last passed: Never
ccextractor --in=raw fb79021542..., Last passed: Never
ccextractor --in=mp4 b2771c84c2..., Last passed: Never
ccextractor --mp4vidtrack 5df914ce77..., Last passed: Never
ccextractor --wtvconvertfix acf871cbfd..., Last passed: Never
ccextractor --wtvmpeg2 10f0f77cf4..., Last passed: Never
ccextractor --hauppauge d6df1b227a..., Last passed: Never
ccextractor --codec dvbsub --out=spupng 85271be4d2..., Last passed: Never
ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
ccextractor --startcreditsnotafter 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
ccextractor --startcreditsforatmost 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
ccextractor --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Never
ccextractor --endcreditsforatleast 3 --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Never
ccextractor --endcreditsforatmost 2 --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Never
ccextractor --tpage 801 4e56e88ba4..., Last passed: Never
ccextractor --tverbose 4e56e88ba4..., Last passed: Never
ccextractor --teletext 4e56e88ba4..., Last passed: Never
ccextractor --out=txt --ucla c83f765c66..., Last passed: Never
ccextractor --xmltv=3 --out=null 96efd279cf..., Last passed: Never
ccextractor --datapid 2310 --autoprogram --out=srt --latin1 e639e54550..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 4e56e88ba4..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 c0d2fba8c0..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 006fdc391a..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 e92a1d4d2a..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 b37ce60eb9..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 7e4ebf7fd7..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 9256a60e4b..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 27d7a43dd6..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 297a44921a..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 efbe129086..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 eae0077731..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 e2e2b501e0..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 8c1615c1a8..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 c6407fb294..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --datets dcada745de..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --tpage 398 5d5838bde9..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --tpage 299 44c45593fb..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --tpage 299 b8c55aa2e9..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --teletext --tpage 398 3b276ad8bf..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 b236a0590b..., Last passed: Never
ccextractor --out=srt --latin1 f23a544ba8..., Last passed: Never
ccextractor --out=srt --latin1 97cc394d87..., Last passed: Never
ccextractor --out=srt --latin1 10f0f77cf4..., Last passed: Never
ccextractor --out=srt --latin1 df3b4d62d3..., Last passed: Never
ccextractor --out=srt --latin1 d7e7dbdf68..., Last passed: Never
ccextractor --out=srt --latin1 76734ac4a7..., Last passed: Never
ccextractor --out=srt --latin1 c791382c94..., Last passed: Never
ccextractor --out=srt --latin1 f673b2f916..., Last passed: Never
ccextractor --out=srt --latin1 da75bdee47..., Last passed: Never
ccextractor --out=srt --latin1 bd6f33a669..., Last passed: Never
ccextractor --out=srt --latin1 0e5e6b26be..., Last passed: Never
ccextractor --out=srt --latin1 a226cc302d..., Last passed: Never
ccextractor --out=srt --latin1 ae6327683e..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 725a49f871..., Last passed: Never
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla d037c7509e..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --ucla d037c7509e..., Last passed: Never
ccextractor --autoprogram --out=smptett --latin1 --ucla e274a73653..., Last passed: Never
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla e274a73653..., Last passed: Never
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla 85058ad37e..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds b22260d065..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --ucla b22260d065..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --xds --ucla c813e713a0..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --ucla c813e713a0..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 27fab4dbb6..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --ucla 27fab4dbb6..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds bbd5bb52fc..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --ucla bbd5bb52fc..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds b992e0cccb..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds d0291cdcf6..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla 7d2730d38e..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --ucla 7d2730d38e..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds c8dc039a88..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --ucla c8dc039a88..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 53339f3455..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --ucla 53339f3455..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 83b03036a2..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --ucla 83b03036a2..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7d3f25c32c..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --ucla 7d3f25c32c..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds f41d4c29a1..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --ucla f41d4c29a1..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 88cd42b89a..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --ucla 88cd42b89a..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --output-field 2 --ucla 88cd42b89a..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7f41299cc7..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --ucla 7f41299cc7..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 0069dffd21..., Last passed: Never

All tests passing on the master branch were passed completely.

Check the result page for more info.

ccextractor-bot · 2025-12-13T07:05:38Z

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 1510396...:

Report Name	Tests Passed
Broken	13/13
CEA-708	14/14
DVB	7/7
DVD	3/3
DVR-MS	2/2
General	27/27
Hardsubx	1/1
Hauppage	3/3
MP4	3/3
NoCC	10/10
Options	86/86
Teletext	21/21
WTV	13/13
XDS	34/34

Congratulations: Merging this PR would fix the following tests:

ccextractor --autoprogram --out=srt --latin1 f1422b8bfe..., Last passed: Never
ccextractor --datapid 5603 --autoprogram --out=srt --latin1 --teletext 85c7fc1ad7..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --quant 0 85271be4d2..., Last passed: Never
ccextractor --hardsubx 1a0302f7fd..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 c0d2fba8c0..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 006fdc391a..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 e92a1d4d2a..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 7e4ebf7fd7..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 9256a60e4b..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 27d7a43dd6..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 297a44921a..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 efbe129086..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 eae0077731..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 e2e2b501e0..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 c6407fb294..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 --datets dcada745de..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --tpage 398 5d5838bde9..., Last passed: Never
ccextractor --autoprogram --out=srt --latin1 --teletext --tpage 398 3b276ad8bf..., Last passed: Never

All tests passing on the master branch were passed completely.

Check the result page for more info.

cfsmp3 force-pushed the fix/mcc-encoder-buffer-overruns branch from 082a0c1 to 37fed5e Compare December 13, 2025 05:23

cfsmp3 merged commit 4a98bf5 into master Dec 13, 2025
30 checks passed

cfsmp3 deleted the fix/mcc-encoder-buffer-overruns branch December 13, 2025 07:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(mcc_encoder): prevent buffer overruns and add OOM checks #1804

fix(mcc_encoder): prevent buffer overruns and add OOM checks #1804

Uh oh!

cfsmp3 commented Dec 13, 2025

Uh oh!

ccextractor-bot commented Dec 13, 2025

Uh oh!

ccextractor-bot commented Dec 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(mcc_encoder): prevent buffer overruns and add OOM checks #1804

fix(mcc_encoder): prevent buffer overruns and add OOM checks #1804

Uh oh!

Conversation

cfsmp3 commented Dec 13, 2025

Summary

Issues Found and Fixed

1. Missing OOM Checks (2 instances)

2. Unsafe sprintf Calls (12 instances)

3. Unsafe strcat Call

4. Unsafe vsprintf in debug_log

5. Inefficient sprintf Loop in random_chars

6. Uninitialized Buffer in Default Case

Code Changes Summary

Security Impact

Test Plan

Uh oh!

ccextractor-bot commented Dec 13, 2025

Uh oh!

ccextractor-bot commented Dec 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

2. Unsafe `sprintf` Calls (12 instances)

3. Unsafe `strcat` Call

4. Unsafe `vsprintf` in `debug_log`

5. Inefficient `sprintf` Loop in `random_chars`