fix(parser): use HHMMSSFFF format for ttxt output timestamps#1806
Merged
fix(parser): use HHMMSSFFF format for ttxt output timestamps#1806
Conversation
The Rust parser was incorrectly setting date_format to HHMMSS (no milliseconds) instead of HHMMSSFFF (with milliseconds) for --out=ttxt. This bug was introduced in PR #1619 when porting the parser to Rust. The original C code correctly used ODF_HHMMSSMS which includes milliseconds in the timestamp format (HH:MM:SS,mmm). Before: 10:25:16 (missing milliseconds) After: 10:25:16,000 (correct format matching original C behavior) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
5d4ce48 to
7113036
Compare
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 77e1dff...:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
All tests passing on the master branch were passed completely. Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 1510396...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression in ttxt output where timestamps were missing milliseconds.
The Rust parser was incorrectly setting
date_formattoTimestampFormat::HHMMSS(no milliseconds) instead ofTimestampFormat::HHMMSSFFF(with milliseconds) for--out=ttxt.This bug was introduced in PR #1619 when porting the parser to Rust. The original C code correctly used
ODF_HHMMSSMSwhich includes milliseconds in the timestamp format (HH:MM:SS,mmm).Before (incorrect)
After (correct, matching original C behavior)
Root Cause
In
src/rust/src/parser.rs, theOutFormat::Ttxthandler was setting:Instead of:
Verification
Tested locally with teletext sample:
Output now correctly includes milliseconds in timestamps.
Test plan
🤖 Generated with Claude Code