fix(rust): Remove dead code returning pointer to stack variable #2012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes unused
impl FromCType<*mut PMT_entry> for *mut PMTEntrywhich contained a critical bug: returning a pointer to a stack-allocated value (undefined behavior).Problem
The deleted code did this:
When the function returns,
pmt_entryis destroyed and the pointer becomes dangling.Why delete instead of fix?
This code was never called anywhere in the codebase:
demuxer.rs:279uses the value-returning variant:PMTEntry::from_ctype(*buffer_ptr)Box::into_raw(Box::new(PMTEntry::from_ctype(...)?))Rather than fix dead buggy code (and introduce memory ownership complexity), just delete it.
Verification
Related
Supersedes #1988 which attempted to fix this bug rather than delete the dead code.
🤖 Generated with Claude Code