[FIX] Guard against NULL timing context when reporting decoder statistics #2061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Summary
This PR adds a defensive NULL check for
dec_ctx->timingin the decoder reporting loop at the end ofstart_ccx().Under certain execution paths, decoder contexts present in
ctx->dec_ctx_headmay not have an associated timing context. The current code unconditionally dereferencesdec_ctx->timing, which can lead to undefined behavior or crashes.This change safely skips such decoder entries during reporting.
Problem Description
The reporting loop in
start_ccx()assumes that every decoder inctx->dec_ctx_headhas a valid timing structure and unconditionally accesses timing fields.While decoders created via
init_cc_decode()always initialize timing, decoder contexts created viacopy_decoder_context()explicitly settiming = NULL. These copied decoder contexts may still be present indec_ctx_head.As a result,
dec_ctx->timingis not guaranteed to be non-NULL at this point.Fix
Add a simple guard before accessing timing fields: