[FIX] Remove unconditional VBI_DEBUG define — add CMake option for opt-in debug builds

[Varadraj75]

In raising this pull request, I confirm the following (please check boxes):

• I have read and understood the contributors guide.
• I have checked that another pull request for this purpose does not exist.
• I have considered, and confirmed that this submission will be valuable to others.
• I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
• I give this submission freely, and claim no ownership to its content.
• I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

• I have never used CCExtractor.
• I have used CCExtractor just a couple of times.
• I absolutely love CCExtractor, but have not contributed previously.
• I am an active contributor to CCExtractor.

---

Summary

Fixes #2167 — VBI_DEBUG was unconditionally defined in ccx_decoders_vbi.h,
causing debug-only struct fields and code paths to always be compiled into
production builds.

Root Cause

// ccx_decoders_vbi.h:4 — before this fix
#define VBI_DEBUG   // ← always defined

This caused debug_file_name and vbi_debug_dump fields to be present in
every build of ccx_decoder_vbi_cfg and ccx_decoder_vbi_ctx, regardless
of whether debug output was needed.

Fix

Removed the unconditional #define VBI_DEBUG from the header and added a
proper CMake option consistent with how other debug flags work in the project:

option (VBI_DEBUG "Enable VBI decoder debug output" OFF)

if (VBI_DEBUG)
  add_definitions(-DVBI_DEBUG)
  message(STATUS "VBI debug output enabled")
endif (VBI_DEBUG)

Developers who need VBI debug output can now opt in explicitly:

cmake .. -DVBI_DEBUG=ON

Comparison

Other debug flags in the codebase (WTV_DEBUG, DEBUG_SAVE_TS_PACKETS) are
never unconditionally defined — they require explicit opt-in. This fix brings
VBI_DEBUG in line with that pattern.

Testing

Built and verified locally on macOS with both VBI_DEBUG=OFF (default)
and VBI_DEBUG=ON. All existing CI tests pass.

Fixes #2167

[Copilot]

Pull request overview

This PR fixes #2167 by removing an always-on VBI_DEBUG preprocessor define from the VBI decoder header and replacing it with an opt-in CMake build option, preventing debug-only VBI fields/paths from being compiled into default production builds.

Changes:

• Removed the unconditional #define VBI_DEBUG from src/lib_ccx/ccx_decoders_vbi.h.
• Added a VBI_DEBUG CMake option intended to conditionally define VBI_DEBUG at compile time.
• Documented the change in docs/CHANGES.TXT.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/lib_ccx/ccx_decoders_vbi.h	Removes unconditional debug macro to avoid always compiling debug-only fields/code.
src/CMakeLists.txt	Adds VBI_DEBUG build option and attempts to define VBI_DEBUG when enabled.
docs/CHANGES.TXT	Changelog entry describing the fix and the new opt-in build flag.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ccextractor-bot]

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit f377be9...:

Report Name	Tests Passed
Broken	13/13
CEA-708	14/14
DVB	7/7
DVD	3/3
DVR-MS	2/2
General	27/27
Hardsubx	1/1
Hauppage	3/3
MP4	3/3
NoCC	10/10
Options	86/86
Teletext	21/21
WTV	13/13
XDS	34/34

Congratulations: Merging this PR would fix the following tests:

• ccextractor --autoprogram --out=srt --latin1 --quant 0 85271be4d2..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65..., Last passed: Never
• ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b..., Last passed: Never
• ccextractor --out=spupng c83f765c66..., Last passed: Never
• ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
• ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
• ccextractor --startcreditsnotafter 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
• ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
• ccextractor --startcreditsforatmost 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never

All tests passed completely.

Check the result page for more info.

[ccextractor-bot]

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit f377be9...:

Report Name	Tests Passed
Broken	13/13
CEA-708	14/14
DVB	6/7
DVD	3/3
DVR-MS	2/2
General	25/27
Hardsubx	1/1
Hauppage	3/3
MP4	3/3
NoCC	10/10
Options	80/86
Teletext	21/21
WTV	13/13
XDS	34/34

Your PR breaks these cases:

• ccextractor --autoprogram --out=srt --latin1 --quant 0 85271be4d2...
• ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65...
• ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b...
• ccextractor --out=spupng c83f765c66...
• ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
• ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
• ccextractor --startcreditsnotafter 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
• ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
• ccextractor --startcreditsforatmost 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

[Varadraj75]

The Windows CI test failures are pre-existing and unrelated to this PR.

All failing tests show Empty path name is not legal — a known Windows
test runner path issue that affects every PR. All these tests show
"Last passed: Never" in the CI summary, confirming they were already
broken on master before this change.

The previous Windows build failure (C2016 empty struct) has been fixed
by adding a reserved member under #ifndef VBI_DEBUG. Windows now
builds and runs cleanly — only the pre-existing path failures remain.

Linux CI passes all tests cleanly.