[FIX] Preserve git commit hash in Homebrew and tarball-based builds#2266
Merged
cfsmp3 merged 1 commit intoCCExtractor:masterfrom Apr 18, 2026
Merged
Conversation
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit ad4886e...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit ad4886e...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
Reason for this PR:
Sanity check:
Repro instructions:
Homebrew
brew install ccextractor ccextractor --version # Git commit: Unknown ← every macOS user sees thisProblem
Tarball-based builds (Homebrew, or any manual build from the released source tarball) have no .git directory at build time. The existing logic in
pre-build.shcallsgit rev-parse HEADunconditionally — when.gitis absent, this fails silently:Every user installing via Homebrew or building from the released source tarball loses build provenance entirely.
Fix
Add explicit override path at the metadata generation point (
pre-build.sh), not post-build output patching.mac/pre-build.sh,linux/pre-build.shCheck
GIT_COMMIT_HASH_OVERRIDEenv var first. If set, use it directly. Otherwise fall through to existing git logic unchanged.mac/build.command,linux/buildNew
-commit-hash <value>argument exportsGIT_COMMIT_HASH_OVERRIDEforpre-build.sh. Matches existing-system-libspattern.src/CMakeLists.txtGIT_COMMIT_HASHCMakeCACHE STRINGfor-DGIT_COMMIT_HASH=<value>. Falls through to git when empty. Placed afterBASE_PROJ_DIRdefinition.Source builds unaffected — override only taken when explicitly provided.
Testing
1. Normal source build (unchanged):
2. Tarball simulation (no .git, no override):
3. Override injection:
4. Full Homebrew end-to-end (production path):
Next step: Once this merges and a new release is cut, a Homebrew-core PR will add
"-commit-hash", "v#{version}"to the formula'sinstallblock — at which point every future Homebrew bottle will carry the correct build provenance automatically.