Skip to content

Some changes to build scripts#24

Closed
rkuchumov wants to merge 4 commits intoCCExtractor:masterfrom
rkuchumov:master
Closed

Some changes to build scripts#24
rkuchumov wants to merge 4 commits intoCCExtractor:masterfrom
rkuchumov:master

Conversation

@rkuchumov
Copy link
Copy Markdown
Member

Maybe we should name each source file with .c suffix.
By some reason there are multiple definitions of gf_utc_time_since_1970() in the code. Functions are literally the same. So I didn't dig it and add -zmuldefs flag to the linker.

@anshul1912
Copy link
Copy Markdown
Contributor

i tried changing all cpp to c but end code was not working(unable to detect closed caption). So I left that as it is.
In my recent pull request, i have changed extension of file dvb_subtitle_decoder.cpp to dvb_subtitle_decoder.c, I think that might conflict in our push to main branch.

I also support to change suffix from .cpp to .c
but changing all file at once will require lots of change

@cfsmp3
Copy link
Copy Markdown
Contributor

cfsmp3 commented May 8, 2014

There's some C++ in CCExtractor that we need to remove first (in SpuPNG - I
didn't notice until a few days ago, in fact there's an issue about it open
in github).

I'm also OK with the change to C, even though the reason for cpp is that it
solved compilations problems I didn't want to investigate at the time.

On Thu, May 8, 2014 at 8:01 AM, Anshul Maheshwari
notifications@github.comwrote:

i tried changing all cpp to c but end code was not working(unable to
detect closed caption). So I left that as it is.
In my recent pull request, i have changed extension of file
dvb_subtitle_decoder.cpp to dvb_subtitle_decoder.c, I think that might
conflict in our push to main branch.

I also support to change suffix from .cpp to .c
but changing all file at once will require lots of change


Reply to this email directly or view it on GitHubhttps://github.com//pull/24#issuecomment-42516018
.

@rkuchumov
Copy link
Copy Markdown
Member Author

I removed C++ stuff from SpuPNG, also I added *.c support for src dir in Makefile, as Anshul wrote.

@cfsmp3
Copy link
Copy Markdown
Contributor

cfsmp3 commented May 9, 2014

Ruslan, can you generate a pull request with only the changes for spupng,
and another one for the Makefile? Note: Just the makefile. build and
builddebug I want to leave untouched because they're very convenient to me.
If someone wants to use make to build they can just type make instead of
./build :-)

On Thu, May 8, 2014 at 9:06 PM, Ruslan notifications@github.com wrote:

I removed C++ stuff from SpuPNG, also I added *.c support for src dir in
Makefile, as Anshul wrote.


Reply to this email directly or view it on GitHubhttps://github.com//pull/24#issuecomment-42591999
.

@cfsmp3 cfsmp3 closed this May 9, 2014
hrideshmg pushed a commit to hrideshmg/ccextractor that referenced this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants