Generate spupng xml and png files in <file_name>.d

[anshul1912]

this pull request contain two commits.
one to separate spupng module out, so that dvbsub decoder can also use it.

another is to generate spupng subtitle from dvbsubtile decoder.

[cfsmp3]

This isn't based against the current github version (which was the
same as last week). It removes all the refactoring work, for example:

-void write_subtitle_file_footer(struct s_context_cc608 *context)
+void write_subtitle_file_footer(struct ccx_s_write *out)

That's a no-go :-) We're using s_context_cc608 (which contains a
pointer to ccx_s_write) as context parameter for the 608 decoder.

A clean patch is needed here.

On Tue, May 13, 2014 at 8:47 PM, Anshul Maheshwari
notifications@github.com wrote:

this pull request contain two commits.
one to separate spupng module out, so that dvbsub decoder can also use it.

another is to generate spupng subtitle from dvbsubtile decoder.

---

You can merge this Pull Request by running

git pull https://github.com/anshul1912/ccextractor master

Or view, comment on, or merge it at:

#28

Commit Summary

Removed dependency of 608cc in reusing spupng
Generate spupng xml and png files in <file_name>.d

File Changes

M src/608.cpp (23)
M src/608.h (19)
M src/608_helpers.cpp (1)
M src/608_spupng.cpp (363)
M src/608_spupng.h (19)
R src/activity.c (0)
A src/activity.h (33)
R src/cc_decoders_common.c (0)
A src/cc_decoders_common.h (23)
M src/ccextractor.cpp (10)
M src/ccextractor.h (86)
M src/constants.h (3)
M src/dvb_subtitle_decoder.c (48)
M src/dvb_subtitle_decoder.h (12)
M src/general_loop.cpp (2)
A src/spupng_xml_enc.c (335)
A src/spupng_xml_enc.h (45)
M src/stream_functions.cpp (33)
R src/timing.c (22)
M src/ts_functions.cpp (10)
M src/ts_tables.cpp (13)
R src/utility.c (57)
A src/utility.h (33)

Patch Links:

https://github.com/CCExtractor/ccextractor/pull/28.patch
https://github.com/CCExtractor/ccextractor/pull/28.diff

—
Reply to this email directly or view it on GitHub.

[anshul1912]

On May 14, 2014 12:28:51 AM IST, cfsmp3 notifications@github.com wrote:

This isn't based against the current github version (which was the
same as last week). It removes all the refactoring work, for example:

-void write_subtitle_file_footer(struct s_context_cc608 *context)
+void write_subtitle_file_footer(struct ccx_s_write *out)

That's a no-go :-) We're using s_context_cc608 (which contains a
pointer to ccx_s_write) as context parameter for the 608 decoder.

A clean patch is needed here.

On Tue, May 13, 2014 at 8:47 PM, Anshul Maheshwari
notifications@github.com wrote:

this pull request contain two commits.
one to separate spupng module out, so that dvbsub decoder can also
use it.

another is to generate spupng subtitle from dvbsubtile decoder.

---

You can merge this Pull Request by running

git pull https://github.com/anshul1912/ccextractor master

Or view, comment on, or merge it at:

#28

Commit Summary

Removed dependency of 608cc in reusing spupng
Generate spupng xml and png files in <file_name>.d

File Changes

M src/608.cpp (23)
M src/608.h (19)
M src/608_helpers.cpp (1)
M src/608_spupng.cpp (363)
M src/608_spupng.h (19)
R src/activity.c (0)
A src/activity.h (33)
R src/cc_decoders_common.c (0)
A src/cc_decoders_common.h (23)
M src/ccextractor.cpp (10)
M src/ccextractor.h (86)
M src/constants.h (3)
M src/dvb_subtitle_decoder.c (48)
M src/dvb_subtitle_decoder.h (12)
M src/general_loop.cpp (2)
A src/spupng_xml_enc.c (335)
A src/spupng_xml_enc.h (45)
M src/stream_functions.cpp (33)
R src/timing.c (22)
M src/ts_functions.cpp (10)
M src/ts_tables.cpp (13)
R src/utility.c (57)
A src/utility.h (33)

Patch Links:

https://github.com/CCExtractor/ccextractor/pull/28.patch
https://github.com/CCExtractor/ccextractor/pull/28.diff

—
Reply to this email directly or view it on GitHub.

---

Reply to this email directly or view it on GitHub:
#28 (comment)

Yaa it grew large, I will make smaller commits from now. Even this I will slice it in digestable chunks. :)

Though I would like to tell that it is based on current git, those functions you were pointing are not removed but moved to spupng_xml_enc.c

I removed s_context_cc608 since that function does not use anything other then out structure.
If we remove cc608 dependency, we can use this function with amy subtitle decoder.
I actually did not understood your intenstion, is it any other information you think, might need to be passed using cc608 structure later?

-Anshul

Sent from my Android device with K-9 Mail. Please excuse my brevity.

[anshul1912]

need to be done in small patch