Skip to content

Added --forceflush (-ff) option#307

Merged
cfsmp3 merged 1 commit intoCCExtractor:masterfrom
nikofil:master
Mar 14, 2016
Merged

Added --forceflush (-ff) option#307
cfsmp3 merged 1 commit intoCCExtractor:masterfrom
nikofil:master

Conversation

@nikofil
Copy link
Copy Markdown
Contributor

@nikofil nikofil commented Mar 11, 2016

Added option for forcing a flush on the output buffer whenever content is written

@nikofil nikofil changed the title Added --forceflush (-ff) option, closes #306 Added --forceflush (-ff) option Mar 11, 2016
@nikofil
Copy link
Copy Markdown
Contributor Author

nikofil commented Mar 11, 2016

@ccx-testerbot runtests master

@ghost
Copy link
Copy Markdown

ghost commented Mar 11, 2016

I'm sorry, but I cannot allow you to issue commands, as this repository is ran locally. Please ask a trusted contributor to run the tests for you instead.

@canihavesomecoffee
Copy link
Copy Markdown
Member

@ccx-testerbot runtests master

@Aesmade I'll run them for you :)

@ghost
Copy link
Copy Markdown

ghost commented Mar 12, 2016

Thank you for the request. It has been added to the queue (id: 178). To see the progress you can go to the status page. Please note that depending on the current queue, it could take a while before any results will be visible. In each case I will report back here once the tests are done.

@ghost
Copy link
Copy Markdown

ghost commented Mar 12, 2016

The test suite finished running the test files. Below is a summary of the test results:

Report name Tests passed
_Broken 11/13
_DVB 5/5
_DVD 0/3
_DVR-MS 0/2
_General 11/27
_Hauppage 0/3
_MP4 2/2
_NoCC 10/10
_Teletext 21/21
_WTV 13/13
_XDS 30/34
_Options 82/87
_DTVCC 11/14

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Please check the results page, and verify those files. If you have a question about this report, please contact @canihavesomecoffee.

@anshul1912
Copy link
Copy Markdown
Contributor

you are changing the default behaviour of ccextractor, now we only force the buffer if -ff option is passed. you are trying to make it optional, may I know the use case, where you find force buffer is not useful and create problem for you.

@canihavesomecoffee
Copy link
Copy Markdown
Member

@anshul1912: It was requested by @cfsmp3, because when he added it it slows down CCExtractor (or at least the bot test run) with 100%, hence his request in #306 to make it optional again

@Aesmade Tests are good, didn't break anything 👍

@cfsmp3 cfsmp3 merged commit 286398c into CCExtractor:master Mar 14, 2016
hrideshmg pushed a commit to hrideshmg/ccextractor that referenced this pull request Mar 12, 2025
Skipped functions with specific decorators (e.g `@template_renderer()`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants