Skip to content

Fix for * to @ issue based on packet address.#325

Closed
abhishek-vinjamoori wants to merge 5 commits intoCCExtractor:masterfrom
abhishek-vinjamoori:Fix
Closed

Fix for * to @ issue based on packet address.#325
abhishek-vinjamoori wants to merge 5 commits intoCCExtractor:masterfrom
abhishek-vinjamoori:Fix

Conversation

@abhishek-vinjamoori
Copy link
Copy Markdown
Contributor

Possible fix. Must do more testing for * , @ and § samples

@abhishek-vinjamoori
Copy link
Copy Markdown
Contributor Author

Text is over-written. Must change the for loops correctly.

@abhishek-vinjamoori
Copy link
Copy Markdown
Contributor Author

Possible fix for #249.
Regression testing required, as data is over-written in special cases.

@canihavesomecoffee
Copy link
Copy Markdown
Member

@ccx-testerbot runtests master

@ghost
Copy link
Copy Markdown

ghost commented Mar 16, 2016

Thank you for the request. It has been added to the queue (id: 187). To see the progress you can go to the status page. Please note that depending on the current queue, it could take a while before any results will be visible. In each case I will report back here once the tests are done.

@ghost
Copy link
Copy Markdown

ghost commented Mar 16, 2016

The test suite finished running the test files. Below is a summary of the test results:

Report name Tests passed
_Broken 11/13
_DVB 3/5
_DVD 0/3
_DVR-MS 0/2
_General 11/27
_Hauppage 0/3
_MP4 2/2
_NoCC 10/10
_Teletext 4/21
_WTV 13/13
_XDS 30/34
_Options 79/87
_DTVCC 11/14

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Please check the results page, and verify those files. If you have a question about this report, please contact @canihavesomecoffee.

@canihavesomecoffee
Copy link
Copy Markdown
Member

Looks good 👍

@canihavesomecoffee
Copy link
Copy Markdown
Member

@ccx-testerbot runtests master

@ghost
Copy link
Copy Markdown

ghost commented Mar 18, 2016

Thank you for the request. It has been added to the queue (id: 189). To see the progress you can go to the status page. Please note that depending on the current queue, it could take a while before any results will be visible. In each case I will report back here once the tests are done.

@ghost
Copy link
Copy Markdown

ghost commented Mar 18, 2016

The test suite finished running the test files. Below is a summary of the test results:

Report name Tests passed
_Broken 11/13
_DVB 3/5
_DVD 0/3
_DVR-MS 0/2
_General 11/27
_Hauppage 0/3
_MP4 2/2
_NoCC 10/10
_Teletext 4/21
_WTV 13/13
_XDS 30/34
_Options 79/87
_DTVCC 11/14

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Please check the results page, and verify those files. If you have a question about this report, please contact @canihavesomecoffee.

@cfsmp3
Copy link
Copy Markdown
Contributor

cfsmp3 commented Mar 18, 2016

Merged a different solution but this one is valid - you get points.
Please mention the PR number in your proposal.

@cfsmp3 cfsmp3 closed this Mar 18, 2016
hrideshmg pushed a commit to hrideshmg/ccextractor that referenced this pull request Mar 12, 2025
…CExtractor#325)

* break progress_reporter into multiple functions

* add test for progress_reporter

* add tests for individual progress type functions

* allow passing request as parameter to progress_reporter handler methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants