Skip to content

Fix * displaying instead of @#337

Merged
cfsmp3 merged 1 commit intoCCExtractor:masterfrom
bigharshrag:Fix249
Mar 18, 2016
Merged

Fix * displaying instead of @#337
cfsmp3 merged 1 commit intoCCExtractor:masterfrom
bigharshrag:Fix249

Conversation

@bigharshrag
Copy link
Copy Markdown
Contributor

Fixes the issue #249 .
Fixed according to X/26 packet specifications in ETS 300 706 v1.2.1 .

@canihavesomecoffee
Copy link
Copy Markdown
Member

@ccx-testerbot runtests master

@ghost
Copy link
Copy Markdown

ghost commented Mar 18, 2016

Thank you for the request. It has been added to the queue (id: 190). To see the progress you can go to the status page. Please note that depending on the current queue, it could take a while before any results will be visible. In each case I will report back here once the tests are done.

@abhishek-vinjamoori
Copy link
Copy Markdown
Contributor

@rishabh This PR is the same as my PR. Or is there any additional change ?

@bigharshrag
Copy link
Copy Markdown
Contributor Author

@abhishek-vinjamoori This commit already includes bug fixes for teletext files from PR #335 . Your commit was before I fixed the bugs. Other than that the fix for issue #249 is similar.

@ghost
Copy link
Copy Markdown

ghost commented Mar 18, 2016

The test suite finished running the test files. Below is a summary of the test results:

Report name Tests passed
_Broken 11/13
_DVB 5/5
_DVD 0/3
_DVR-MS 0/2
_General 11/27
_Hauppage 0/3
_MP4 2/2
_NoCC 10/10
_Teletext 21/21
_WTV 13/13
_XDS 30/34
_Options 82/87
_DTVCC 11/14

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Please check the results page, and verify those files. If you have a question about this report, please contact @canihavesomecoffee.

@cfsmp3 cfsmp3 merged commit 3c3f7af into CCExtractor:master Mar 18, 2016
@bigharshrag bigharshrag deleted the Fix249 branch March 19, 2016 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants