Skip to content

Conversation

@canihavesomecoffee
Copy link
Member

The <> make the build fail in Release mode in Visual Studio, as the <>
makes it look for a standard header
(https://msdn.microsoft.com/query/dev14.query?appId=Dev14IDEF1&l=EN-US&k=k(C1083)&rd=true).
This change makes it compile both in Debug and Release mode.

The <> make the build fail in Release mode in Visual Studio, as the <>
makes it look for a standard header
(https://msdn.microsoft.com/query/dev14.query?appId=Dev14IDEF1&l=EN-US&k=k(C1083)&rd=true).
This change makes it compile both in Debug and Release mode.
@cfsmp3
Copy link
Contributor

cfsmp3 commented Sep 6, 2016

We can't modify this file:

/* Generated by the protocol buffer compiler. DO NOT EDIT! /
/
Generated from: ccx_sub_entry_message.proto */

Changes are overwritten each time it's generated, so we need to change the
directories in the project files I'm afraid.

On Sat, Sep 3, 2016 at 3:05 AM, Willem notifications@github.com wrote:

The <> make the build fail in Release mode in Visual Studio, as the <>
makes it look for a standard header
(https://msdn.microsoft.com/query/dev14.query?appId=
Dev14IDEF1&l=EN-US&k=k(C1083)&rd=true).

This change makes it compile both in Debug and Release mode.

You can view, comment on, or merge this pull request online at:

#418
Commit Summary

  • Fix include

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#418, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFrJ2SnDM1Lnx7bvsdIMxrLj-Y7bGmynks5qmUZtgaJpZM4J0RW7
.

@Dakta
Copy link

Dakta commented Sep 11, 2016

Bumping to note that this issue affects Mac build as well. Works on Linux (tested with a Ubuntu 14 instance I had sitting around).

@cfsmp3
Copy link
Contributor

cfsmp3 commented Sep 12, 2016

@Dakta This PR cannot be applied - please open a issue instead.

@cfsmp3 cfsmp3 closed this Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants