Fixed bug with -out=null#475
Merged
cfsmp3 merged 1 commit intoCCExtractor:masterfrom Dec 5, 2016
Izaron:out-null-bug
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://codein.withgoogle.com/dashboard/task-instances/5591734023094272/
I checked the correctness (I had segfault too).
Falling test - the only test that has an argument
-out=null. But I checked some other files, and they too gave segfault with-out=null.How is it? Firstly, after this line #1
enc_ctxbecomes NULL (from function #2), and we get an error in this line #3If we run it with other files, then we almost always get an segfault error in other places associated with the fact that
enc_ctx = NULL.I have added the necessary checks, and now works well.