-
Notifications
You must be signed in to change notification settings - Fork 539
Split to sentences implementation #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
fix maxkoryukov#1 |
| return wrote_something; | ||
| } | ||
| else | ||
| // Write subtitles as they come |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lot of changes lines. BUT, the most changes - deleted symbol. Just ignore whitespaces here:
https://github.com/CCExtractor/ccextractor/pull/491/files?w=1
| // in sentences | ||
| if (sub->type == CC_BITMAP) | ||
| wrote_something = write_cc_bitmap_to_sentence_buffer(sub, context); | ||
| sub = reformat_cc_bitmap_through_sentence_buffer(sub, context); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the most important point in this PR.
SBS works as transformation filter. It takes incoming subs, and convert them to other subs with sub->type = CC_TEXT. This transformation occurred before all other encoders, so other encoders remain unchanged.
| @@ -0,0 +1,11 @@ | |||
| #ifndef _DEBUG_DEF_H_ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a helper for debugging. You could remove this file, and all references to LOG_DEBUG... But they are useful for debugging (with existing tests)
| @@ -0,0 +1,59 @@ | |||
| SHELL = /bin/sh | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new tests folder contains unit-tests for SBS. They are written with libcheck
There is README.md, with short how-to instructions.
|
@cfsmp3, @canihavesomecoffee , is there a chance to merge this to the upstream? |
|
Not for 0.83 (which will be released today). Could happen for 0.84. Note
though that most likely you PR won't merge now since there's been many
changes, so you may need to resubmit.
…On Wed, Dec 14, 2016 at 5:38 AM, Maksim Koryukov ***@***.***> wrote:
@cfsmp3 <https://github.com/cfsmp3>, @canihavesomecoffee
<https://github.com/canihavesomecoffee> , is there a chance to merge this
to the upstream?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#491 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFrJ2WREdhE7S6PrKxbnn3RFVqZW663yks5rH_FQgaJpZM4LHmbu>
.
|
Hello!
This PR contains the implementation of Sentence Buffer: Split
Usage:
./ccextractor -sbs ~/source.tsCurrently, it works only with
sub->type == CC_BITMAP. Implementation details - in comments to the PR.Long example
New output
Old output