Skip to content

Conversation

@Izaron
Copy link
Member

@Izaron Izaron commented Dec 12, 2016

Issue #430

default

This is not a bug - this function is only realised for Teletext files
I radically enabled it for all subtitles
Checked on the .bin file, works well

@cfsmp3
Copy link
Contributor

cfsmp3 commented Dec 12, 2016

This is touching a really sensitive thing :-) have you checked it doesn't break anything when -unixts is not used? What about other formats?

@Izaron
Copy link
Member Author

Izaron commented Dec 13, 2016

Sorry, I had to explain my actions.
Initially, the global variable utc_refvalue is equals to UINT64_MAX
If we use -unixts, then we change this value - see line https://github.com/CCExtractor/ccextractor/blob/master/src/lib_ccx/params.c#L1943

In fact, the assignment is performed in another piece of code - see line https://github.com/CCExtractor/ccextractor/blob/master/src/lib_ccx/telxcc.c#L1271, but we do not break the program, because opt->noautotimeref= 1 after -unixts and we will not perform the second assignment

In teletext uses its own variable to correct subtitle time - https://github.com/CCExtractor/ccextractor/blob/master/src/lib_ccx/telxcc.c#L127

I've included it for all formats

ADDED: So if we dont use -unixts, anything doesn't break because utc_refvalue is equals to UINT64_MAX. I checked many formats, works well.

@cfsmp3 cfsmp3 merged commit d12600e into CCExtractor:master Dec 13, 2016
hrideshmg pushed a commit to hrideshmg/ccextractor that referenced this pull request Mar 12, 2025
Bumps [sqlalchemy](https://github.com/sqlalchemy/sqlalchemy) from 1.4.3 to 1.4.5.
- [Release notes](https://github.com/sqlalchemy/sqlalchemy/releases)
- [Changelog](https://github.com/sqlalchemy/sqlalchemy/blob/master/CHANGES)
- [Commits](https://github.com/sqlalchemy/sqlalchemy/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants